change external controller

xcodeassociated · Sep 17, 2024 · d9b0256 · d9b0256
1 parent 4dcdb13
commit d9b0256
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 4 deletions.
diff --git a/src/main/kotlin/com/softeno/template/sample/http/external/api/ExternalController.kt b/src/main/kotlin/com/softeno/template/sample/http/external/api/ExternalController.kt
@@ -18,9 +18,11 @@ class ExternalController(
     private val log = LogFactory.getLog(javaClass)
 
     @GetMapping("/{id}")
-    fun getExternalResource(@PathVariable id: String): ResponseEntity<String> {
+    fun getExternalResource(@PathVariable id: String): ResponseEntity<SampleResponseDto> {
         val data = externalServiceClient.fetchExternalResource(id)
         log.info("External: Received $id, sending: ${data.toString()}")
-        return ResponseEntity.ok(data)
+        return ResponseEntity.ok(SampleResponseDto(data = data ?: "null"))
     }
-}
+}
+
+data class SampleResponseDto(val data: String)
diff --git a/src/test/kotlin/com/softeno/template/app/IntegrationTest.kt b/src/test/kotlin/com/softeno/template/app/IntegrationTest.kt
@@ -186,7 +186,11 @@ class ExternalControllerTest : BaseIntegrationTest(), ExternalApiAbility {
             .exchange()
             .expectStatus().isOk()
             .expectBody()
-            .jsonPath("data").isEqualTo("1")
+            .jsonPath("data").isEqualTo("""
+                {
+                    "data": "1"
+                }
+            """.trimIndent())
     }
 }