Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_mute, get_volume and set_volume #1

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

get_mute, get_volume and set_volume #1

wants to merge 4 commits into from

Conversation

giefca
Copy link

@giefca giefca commented Oct 18, 2019

Your component is really fast compared to mine. If you want I've made modifications to yours to add my upnp commands to get volume and mute state in HA. You can test it and add it to your component if you want.

jaruba added a commit to jaruba/ha-samsungtv-tizen that referenced this pull request Dec 1, 2019
@jaruba
Copy link

jaruba commented Dec 1, 2019

I've added your changes to my fork at: https://github.com/jaruba/ha-samsungtv-custom/

Other improvements:

  • Voice assistant support (turn on / off, volume up / down, set volume to %, change input source to X)
  • Key chaining: source_list: '{"TV":"KEY_SOURCE+KEY_LEFT+KEY_LEFT+KEY_ENTER"}

@giefca
Copy link
Author

giefca commented Jan 18, 2020

@jaruba thanks, I just saw your fork on ha forums and recognize my code in it. I will follow your work to see what features you can add. I managed to add music and video playback with the play_media service. I can make a PR on your fork if you want. I wanted to add notifications but I can't find a way to do it.

@jaruba
Copy link

jaruba commented Jan 24, 2020

@giefca You mean you got play_media to work through DLNA casting? That would be interesting, as it might work with Voice Commands too..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants