Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More responsive auto-hide window #1669

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

kice
Copy link

@kice kice commented Jul 7, 2021

On my PC with VS debugging, looks like it will take around 0~200ms to execute auto hide; expect to be a lot sooner if it is release build with no debugger attach.

Waiting 1.5 seconds for auto-hide kicks in will make me close the window instead.

On my PC with VS debugging, looks like it will take around 0~200ms to execute auto hide; expect to be a lot sooner if it is release build with no debugger attach.

~~Waiting 1.5 seconds for auto-hide kicks in will make me close the window instead.~~
@XceedBoucherS
Copy link
Collaborator

Hi,

following your comment, the file AutoHideWindow has been reviewed. The fix will slightly differ from your solution.
Here's how it will react in v4.3:
There will be 2 timers.
-1st timer: with an interval of 50ms, will check if need to close the AutoHideWindow. If no, will check back in 50ms. If yes, it will start a 2nd timer.
-2nd timer: with a customizable interval, will check if need to close the AutoHideWindow. If no, will close the 2nd timer and reactivate the 1st timer. If yes, it will close the AutoHideWindow.
Since the 1st timer has a small interval, you won't really notice it. The 2nd timer will let you customize any interval (fast or slow) to close the AutoHideWindow.

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants