Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[addons] dont show addons from disabled repos in 'All repositories' #6992

Merged
merged 1 commit into from
Apr 21, 2015

Conversation

tamland
Copy link
Member

@tamland tamland commented Apr 20, 2015

Currently 'All repositories' lists addons from disabled repositories too, which is weird if you ask me. We don't check for updates in disabled repos for instance.

@da-anda
Copy link
Member

da-anda commented Apr 20, 2015

makes sense IMO

@MartijnKaijser
Copy link
Member

yep

@mkortstiege
Copy link
Member

Formatting is a bit off. Other than that looks good.

@tamland
Copy link
Member Author

tamland commented Apr 21, 2015

@mkortstiege I don't see it. How would you format it?

@mkortstiege
Copy link
Member

Current one looks a bit random to me (next line with some spaces) :p
What about https://gist.github.com/mkortstiege/9376832eb816fb4d8cff instead of newline. Or indent with 2 spaces if you prefer this.

@tamland
Copy link
Member Author

tamland commented Apr 21, 2015

It's not random; statements broken over multiple lines are double indented. I think that's a common style in many languages but whatever:p

@mkortstiege
Copy link
Member

OK, keep it.

@tamland tamland force-pushed the hide-disabled-repos branch from e673204 to db65e8d Compare April 21, 2015 15:30
@tamland
Copy link
Member Author

tamland commented Apr 21, 2015

Too late;)

tamland added a commit that referenced this pull request Apr 21, 2015
[addons] dont show addons from disabled repos in 'All repositories'
@tamland tamland merged commit febf237 into xbmc:master Apr 21, 2015
@tamland tamland deleted the hide-disabled-repos branch August 9, 2015 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants