Split version number with regex #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is so that the same regex can be used in the add-on checker. It was tested to run fine with all current add-ons (except the special case pvr.waipu, which the author was asked to change).
yol
commented
Feb 28, 2021
| parts = result[0].rsplit("-", 1) | ||
| if parts and re.match(r"^[\w.\-@]+$", parts[0]) and re.match(r"^\d+\.\d+(\.\d+){0,4}([+~\w.]+)?$", parts[1]): | ||
| return tuple(parts) | ||
| m = re.match(r"^([\w\.]+.*)-(\d+\.\d+(\.\d+){0,4}([+~\w]+(\.\d+)?)?)$", result[0]) |
There was a problem hiding this comment.
Should we be more strict with package names and not allow .*?
|
I wouldn't. We've tried the sticter approaches and failed :P |
|
The regex that is there now ( |
|
I guess it's fine if just the add-on checker uses the stricter variant @enen92 |
|
Maybe it's better to add a check for the version instead of the regex, that way we have a bit more freedom to check whatever we see fit. I'll try to have a look after work |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Third time's the charm!