fix shows import #67
Merged
fix shows import #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trakt sync api returns `episodes` field even when sync is for whole shows. This makes using `options.type` as key in `result['added']` dict impossible, since result won't have this key. To solve this issue, I'm using `Counter` object (instead of standard dict), which sums `added` and `updated`. For `not_found` I decided that it would make sense to aggregate data instead of only showing counter (since it should be useful to know what wasn't imported).
|
thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trakt sync api returns
episodesfield even when sync is for whole shows.This makes using
options.typeas key inresult['added']dict impossible, since result won't have this key.To solve this issue, I'm using
Counterobject (instead of standard dict), which sumsaddedandupdated.For
not_foundI decided that it would make sense to aggregate data instead of only showing counter (since it should be useful to know what wasn't imported).