mysql: make new settings optional

xbezdick · Aug 21, 2015 · d7386ae · d7386ae
1 parent 8520ac4
commit d7386ae
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 3 deletions.
diff --git a/manifests/plugin/mysql/database.pp b/manifests/plugin/mysql/database.pp
@@ -9,20 +9,28 @@
   $masterstats        = false,
   $slavestats         = false,
   $socket             = undef,
-  $innodbstats        = false,
-  $slavenotifications = false,
+  $innodbstats        = undef,
+  $slavenotifications = undef,
 ) {
   include collectd::params
   include collectd::plugin::mysql
 
   $conf_dir = $collectd::params::plugin_conf_dir
 
   validate_string($database, $host, $username, $password, $port)
-  validate_bool($masterstats, $slavestats, $innodbstats, $slavenotifications)
+  validate_bool($masterstats, $slavestats)
   if $socket {
     validate_string($socket)
   }
 
+  if $innodbstats != undef {
+    validate_bool($innodbstats)
+  }
+
+  if $slavenotifications != undef {
+    validate_bool($slavenotifications)
+  }
+
   if ($masterstats == true and $slavestats == true) {
     fail('master and slave statistics are mutually exclusive.')
   }

diff --git a/templates/mysql-database.conf.erb b/templates/mysql-database.conf.erb
@@ -15,7 +15,11 @@
 <%- if @socket -%>
     Socket "<%= @socket %>"
 <%- end -%>
+<%- if not @innodbstats.nil? -%>
     InnodbStats <%= @innodbstats %>
+<%- end -%>
+<%- if not @slavenotifications.nil? -%>
     SlaveNotifications <%= @slavenotifications %>
+<%- end -%>
   </Database>
 </Plugin>