Skip to content

Commit

Permalink
Remove glance_notifications from notification_topic
Browse files Browse the repository at this point in the history
The default notification_topic in Glance has been changed from
'glance_notifications' to 'notifications' in grizzly-2.

Ceilometer was configured to also listen on the
'glance_notifications' notification_topic in addition to
'notifications' to patch this bug. It shouldn't anymore.

Change-Id: I3d797c7e849319a1e20ef3ecbf158e8b8579d450
Closes-bug: #1273876
  • Loading branch information
mgagne committed Jan 28, 2014
1 parent 3685997 commit 924f18f
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 8 deletions.
8 changes: 2 additions & 6 deletions manifests/init.pp
Original file line number Diff line number Diff line change
Expand Up @@ -183,13 +183,9 @@
'DEFAULT/log_dir' : value => $log_dir;
'DEFAULT/verbose' : value => $verbose;
# Fix a bad default value in ceilometer.
# Fixed in https: //review.openstack.org/#/c/18487/
# Fixed in https://review.openstack.org/#/c/18487/
'DEFAULT/glance_control_exchange': value => 'glance';
# Add glance-notifications topic.
# Fixed in glance https://github.com/openstack/glance/commit/2e0734e077ae
# Fix will be included in Grizzly
'DEFAULT/notification_topics' :
value => 'notifications,glance_notifications';
'DEFAULT/notification_topics' : value => 'notifications';
}

# Syslog configuration
Expand Down
4 changes: 2 additions & 2 deletions spec/classes/ceilometer_init_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -148,8 +148,8 @@
should contain_ceilometer_config('DEFAULT/glance_control_exchange').with_value('glance')
end

it 'adds glance-notifications topic' do
should contain_ceilometer_config('DEFAULT/notification_topics').with_value('notifications,glance_notifications')
it 'configures notification_topics' do
should contain_ceilometer_config('DEFAULT/notification_topics').with_value('notifications')
end
end

Expand Down

0 comments on commit 924f18f

Please sign in to comment.