Merge pull request redhat-openstack#247 from hunner/TelekomCloud-feat…

…ure/no_ulc_by_default

No Undisciplined Local Clock by default

README.markdown

@@ -259,7 +259,7 @@ Tells Puppet what NTP service to manage. Valid options: string. Default value: v
 
 ####`udlc`
 
-Specifies whether to configure ntp to use the undisciplined local clock as a time source, regardless of the node's status as a virtual machine. Valid options: 'true' or 'false'. Default value: 'false' for VMs and 'true' otherwise.
+Specifies whether to configure ntp to use the undisciplined local clock as a time source. Valid options: 'true' or 'false'. Default value: 'false'
 
 ##Limitations
 

manifests/params.pp

@@ -13,6 +13,7 @@
   $service_enable    = true
   $service_ensure    = 'running'
   $service_manage    = true
+  $udlc              = false
   $interfaces        = []
   $disable_auth      = false
   $broadcastclient   = false
@@ -28,15 +29,6 @@
     default => true,
   }
 
-  # On virtual systems, disable the use of the undisciplined local clock to
-  # avoid ntp falling back to the local clock in preference over ntp servers.
-  # TODO Change this to str2bool($::is_virtual) when stdlib dependency is >= 4
-  # NOTE The "x${var}" is just to avoid lint quoted variable warning.
-  $udlc = "x${::is_virtual}" ? {
-    'xtrue' => false,
-    default => true,
-  }
-
   $default_config       = '/etc/ntp.conf'
   $default_keys_file    = '/etc/ntp/keys'
   $default_driftfile    = '/var/lib/ntp/drift'