test the interface not the result

xbezdick · Jan 16, 2015 · 55054bd · 55054bd
1 parent 9276be2
commit 55054bd
Showing 1 changed file with 8 additions and 11 deletions.
diff --git a/spec/classes/collectd_plugin_java_spec.rb b/spec/classes/collectd_plugin_java_spec.rb
@@ -7,12 +7,11 @@
 
   context ':ensure => present, defaults' do
     it 'Will load the plugin' do
-      should contain_file('java.load').with({
+      should contain_collectd__plugin('java').with({
         :ensure => 'present',
-        :path => '/etc/collectd.d/10-java.conf',
       })
 
-      should contain_file('java.load').without_content(/JVMArg/)
+      should contain_collectd__plugin('java').without_content(/JVMArg/)
     end
   end
 
@@ -22,9 +21,8 @@
     }}
 
     it 'will not load the plugin' do
-      should contain_file('java.load').with({
-        :ensure => 'absent',
-        :path => '/etc/collectd.d/10-java.conf',
+      should contain_collectd__plugin('java').with({
+        :ensure => 'absent'
       })
     end
   end
@@ -35,7 +33,7 @@
     }}
 
     it 'will have multiple JVMArg bits' do
-      should contain_file('java.load').with_content(/JVMArg "foo"[\s\n]+JVMArg "bar"[\s\n]+JVMArg "baz"/)
+      should contain_collectd__plugin('java').with_content(/JVMArg "foo"[\s\n]+JVMArg "bar"[\s\n]+JVMArg "baz"/)
     end
   end
 
@@ -45,11 +43,11 @@
     }}
 
     it 'will have a JVMArg bit' do
-      should contain_file('java.load').with_content(/JVMArg "bat"/)
+      should contain_collectd__plugin('java').with_content(/JVMArg "bat"/)
     end
 
     it 'will only have one JVMArg bit' do
-      should contain_file('java.load').without_content(/(.*JVMArg.*){2,}/)
+      should contain_collectd__plugin('java').without_content(/(.*JVMArg.*){2,}/)
     end
   end
 
@@ -59,8 +57,7 @@
     }}
 
     it 'will not have a <Plugin java> stanza' do
-      should contain_file('java.load').without_content(/<Plugin java>/)
+      should contain_collectd__plugin('java').without_content(/<Plugin java>/)
     end
   end
 end
-