Use Foundry instead of Truffle #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This replaces Truffle to build the integrated smart contracts to Foundry. We use forge to build all the Solidity code, run the unit tests (recoded in Solidity), and update various places that access the build artefacts to the new path structure from Foundry. Dependencies (in particular, the XayaAccounts contract) are included now as git submodules, rather than via npm. The Docker build is updated, too. Since it seems very hard to install Foundry in Alpine (using prebuilt binaries that depend on glibc), we switch the Docker build to be based on Ubuntu.
For integration testing on EVM chains (also the environment that will be used from libxayagame), use Foundry's anvil instead of ganache.
domob1812
added a commit
that referenced
this pull request
Oct 19, 2024
Use Foundry instead of Truffle
domob1812
added a commit
to xaya/libxayagame
that referenced
this pull request
Oct 19, 2024
With xaya/xayax#10, the Xaya X integration testing framework for EVM chains has been changed to use Foundry's anvil instead of ganache. This updates the xayagametest code (which uses the base logic from Xaya X' module) slightly as needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the build system and other places in the code to use Foundry's
forgeinstead of truffle to build and test the included smart contracts (used as part of the EVM chain integration with Xaya X). The unit tests have been recoded in Solidity. Truffle has been sunset, so this ensures that the code is future proofed.The Docker file is updated to be based on Ubuntu now instead of Alpine, since it seems very hard to get the prebuilt Foundry binaries, which depend on glibc, to run on there.
The integration testing framework (which is then also used by any game integration tests running on EVM chains such as Soccerverse) is updated to use Foundry's
anvilinstead ofganache, too.