ICTC-G-1 bug fix #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great solution @EPMatt and thanks for your contribution. I will create a new release at some point today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a bug fix for the last issue described in PR #5.
The issue was caused by some
rotate_left/rotate_rightevents sent in conjunction with therotate_left_quickmessage, which is used to turn the bulb off. These unwanted messages triggered a dimming action which was not stopped by theself.off()call, thus continuing to change brightness after the lamp was turned off, with the result of the lamp being turned on again or, in some cases, the lamp not being turned off and having its brightness dimmed down.Calling the
self.release()method before turning the light off or full on ensures that any dimming action currently running stops and doesn't affect the bulb brightness anymore.Succesfully tested with
delay : 50in the app configuration.