Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tuya TS0043 as a cover remote controller #1076

Merged

Conversation

ChristopheBraud
Copy link
Contributor

Add Tuya as a cover remote controller

I use Open and Close action rather than toggle actions as there is already a stop button on the controller.
There's also a weird behavior with toggle actions where toggle_open stop a closing action rather than opening the cover.

fix #1075

Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95%. Comparing base (3ca3c86) to head (ef87f41).
Report is 6 commits behind head on main.

Additional details and impacted files
@@         Coverage Diff          @@
##           main   #1076   +/-   ##
====================================
  Coverage    95%     95%           
====================================
  Files        65      65           
  Lines      2710    2713    +3     
====================================
+ Hits       2579    2582    +3     
  Misses      131     131           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xaviml xaviml merged commit 2cbf369 into xaviml:main Nov 8, 2024
12 checks passed
@xaviml
Copy link
Owner

xaviml commented Nov 8, 2024

Hi @ChristopheBraud ,

Thank you for your PR. Everything looks good to me, soI will release now.

Regards,

@xaviml
Copy link
Owner

xaviml commented Nov 8, 2024

This device is now released on ControllerX v4.28.0.

@ChristopheBraud ChristopheBraud deleted the feat/TS0043_as_a_cover_controller branch November 13, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[NEW DEVICE] Tuya TS0043 is also designed as a cover controller
2 participants