fix crashing of promise hooks when not under a node context

Fixes issue nodejs#19104
xaviergonz · Mar 4, 2018 · d8b34c4 · d8b34c4
1 parent f2d9379
commit d8b34c4
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/src/env.cc b/src/env.cc
@@ -298,7 +298,12 @@ bool Environment::EmitNapiWarning() {
 void Environment::EnvPromiseHook(v8::PromiseHookType type,
                                  v8::Local<v8::Promise> promise,
                                  v8::Local<v8::Value> parent) {
-  Environment* env = Environment::GetCurrent(promise->CreationContext());
+  auto context = promise->CreationContext();
+  // if the context is undefined (not a node context) then skip
+  if (context->GetEmbedderData(32)->IsNullOrUndefined()) {
+    return;
+  }
+  Environment* env = Environment::GetCurrent(context);
   for (const PromiseHookCallback& hook : env->promise_hooks_) {
     hook.cb_(type, promise, parent, hook.arg_);
   }