Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement pnpm and add --package-manager option #8

Merged
merged 2 commits into from
Apr 7, 2020
Merged

Implement pnpm and add --package-manager option #8

merged 2 commits into from
Apr 7, 2020

Conversation

duykhang53
Copy link
Contributor

  • Implement install for pnpm;
  • Add option to specify package manager;

@duykhang53
- Implement install for pnpm;
cd4bf49 
- Add option to specify package manager;
xavdid
xavdid reviewed Apr 5, 2020
View reviewed changes
Copy link
Owner

@xavdid xavdid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I've asked for a couple of small tweaks but this is cool.

package-lock.json Outdated Show resolved Hide resolved
src/cli.ts Outdated
@@ -14,6 +14,7 @@ program
.option('-d, --dev', 'save everything into the dev dependencies')
.option('-p, --prod', 'save the @types into `dependencies`')
.option('-y, --yarn', 'install using yarn instead of npm')
.option('-pm, --package-manager <packageManager>', 'specify package manager (npm|yarn|pnpm)')
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commander parses multicharacter flags ambiguously (example). Can you swap pm to either p or m?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will use m

@duykhang53
- Reverse package.json version;
7b58ca5 
- Update packageManager flag;
@duykhang53
Copy link
Contributor Author

I mostly use yargs and minimist but thanks for inform me that issue.

@xavdid xavdid merged commit 18422f7 into xavdid:master Apr 7, 2020
@xavdid
Copy link
Owner

xavdid commented Apr 8, 2020

Ok, released as v1.1.0. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xavdid xavdid xavdid left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@duykhang53 @xavdid