DJ June 2023 #182
Closed
DJ June 2023 #182
Commits on Jun 26, 2023
Commits on Jul 2, 2023
Commits on Jul 7, 2023
Commits on Jul 12, 2023
Commits on Jul 13, 2023
Commits on Jul 14, 2023
Commits on Jul 15, 2023
Commits on Jul 16, 2023
Commits on Jul 17, 2023
-
-
-
-
-
I guess removal of those paragraphs was not intended. Not sure about re-adding the Story ideas though, will sort it in next commit.
-
-
-
-
-
-
Commits on Jul 18, 2023
Commits on Jul 21, 2023
-
-
-
Dev DEX reword truncation error
This was a deeply confusing issue. Taking a stab at improving text and documenting why I made each change to feel a bit better about the time spent: - Added "after a crash" to the opening sentence to quickly communicate the scope of the problem before we blast the reader with details. - Changed first link to the Badger announcement blog, it's a better and higher-level summary of crash resilience. - Reworded to not say that storing data in memory saves from data loss, which is confusing without clarification. - Clarified how mmapped files are used to achieve crash resilience. - Reworded to say that overallocation is made by Badger and not by Windows. - Added a direct link to Badger dev comment on how it works on Windows. tbh I'm not sure their explanation is complete or accurate but it is their territory and we can quote that. - Changed to say Badger is over-allocating the file, not memory. Both are correct but its the over-exteded file that is the problem. - Changed to say that it is again Badger that does the truncation of its value log file and not Windows. - Changed to say that the *file* is getting truncated and not *memory allocation*. - Changed to say that truncation is done before "resuming normal operation" and not before "writing to disk". It was not inaccurate, but I think the new version better reflects the sequence "truncate -> open vlog -> read vlog and possibly recover data -> write to vlog". - Changed the Windows vs other OS bit to be more specific: on Unix, it may be a bad sign, on Windows, it is *highly likely* normal operation. - Changed the "no data loss" link to a better comment which answers a good question (how do you tell if the truncation was a normal Windows- specific flow and not real data corruption/loss?). Still calling it a "workaround" because I still don't know if data loss is possible. Specifically, I don't know how that truncation works. Does it only remove the trailing zeroes or can it also kill some unsaved data? No idea, but I'll stop here and defer to their dev comments.
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
Commits on Jul 22, 2023
Commits on Jul 23, 2023
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.