Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change MessengerUtil strings to be more informative #69

Closed
Raud0 opened this issue Nov 30, 2020 · 3 comments
Closed

Change MessengerUtil strings to be more informative #69

Raud0 opened this issue Nov 30, 2020 · 3 comments
Assignees
Labels
documentation Improvements or additions to documentation feature New feature or request low priority
Milestone

Comments

@Raud0
Copy link
Collaborator

Raud0 commented Nov 30, 2020

While I was creating the readme, I discovered that our naming convention could be better standardized for context parameters. For example 'payload' should be 'xatkit.messenger.payload'. Or perhaps even 'messenger.payload'? Not really sure.

@Raud0 Raud0 added feature New feature or request low priority labels Nov 30, 2020
@Raud0 Raud0 added this to the Iteration 4 milestone Nov 30, 2020
@Raud0 Raud0 added the documentation Improvements or additions to documentation label Nov 30, 2020
@Raud0
Copy link
Collaborator Author

Raud0 commented Nov 30, 2020

Oh also, there's a typo. 'refferal' -> 'referral'

@taidopurason
Copy link
Collaborator

Improved the naming convention of the keys/constants in MessengerUtils. I think the configuration keys will require some documentation in code as well, but perhaps that should go under another issue.

@Raud0, can you review the changes?

@Raud0
Copy link
Collaborator Author

Raud0 commented Dec 4, 2020

Yup, this looks way more structured and solves the gripes I had about some inconsistencies on the use of xatkit.messenger. And their grouping looks good as well, if you're just looking at the code and not the README.

There being a difference between mid and mids, which are pretty much the same thing, still annoys me, but that's on Facebook and their naming convention.

@Raud0 Raud0 closed this as completed Dec 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation feature New feature or request low priority
Projects
None yet
Development

No branches or pull requests

2 participants