Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up bulk processor flush and cut release #187

Merged
merged 8 commits into from
Dec 14, 2023
Merged

Speed up bulk processor flush and cut release #187

merged 8 commits into from
Dec 14, 2023

Conversation

philkra
Copy link
Contributor

@philkra philkra commented Dec 14, 2023

  • improve through put of flushing the bulk processor
  • set release artefacts

@philkra philkra added helpers/bulk-processor Everything related to the BulkProcessor release Prepare release labels Dec 14, 2023
@philkra philkra requested a review from kostasb December 14, 2023 11:32
@kostasb
Copy link
Contributor

kostasb commented Dec 14, 2023

Consistency and speed issues are resolved.

The queue's stats are slightly off by one or two batches.

Example, for a dataset with 10k records and default parameters:

bp.flush_queue()
print(bp.stats)

Output:
{'total': 9975, 'queue': 0, 'failed_batches': 0, 'total_batches': 399, 'tables': {'test': 9975}}

Copy link
Contributor

@kostasb kostasb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works well.

@philkra philkra merged commit 1eb8d7b into main Dec 14, 2023
1 check failed
@philkra philkra deleted the release/1.2.2 branch December 14, 2023 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:public helpers/bulk-processor Everything related to the BulkProcessor release Prepare release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants