Speed up make examples
#403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous versionw was building the pgroll command before every example run. Instead, build the command once at the beginning and remove it at the end.
|
@andrew-farries Do we want to somehow use this during CI to confirm examples run correctly? |
kvch
approved these changes
Oct 15, 2024
andrew-farries
approved these changes
Oct 15, 2024
There was a problem hiding this comment.
Nice 👍
We already test examples in CI here:
https://github.com/xataio/pgroll/blob/main/.github/workflows/build.yml#L127
It doesn't use make examples though; it should probably do so.
|
I'll see if I can get it to use the Makefile in this PR |
kvch
pushed a commit
to kvch/pgroll
that referenced
this pull request
Oct 16, 2024
The previous version was building the pgroll command before every example run. Instead, build the command once at the beginning and remove it at the end.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous version was building the pgroll command before every example run. Instead, build the command once at the beginning and remove it at the end.