Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash when connecting to PostgreSQL rc version #393

Merged
merged 1 commit into from
Oct 13, 2024
Merged

Fix crash when connecting to PostgreSQL rc version #393

merged 1 commit into from
Oct 13, 2024

Conversation

songlim327
Copy link
Contributor

Fixes #386

andrew-farries
andrew-farries approved these changes Oct 13, 2024
View reviewed changes
Copy link
Collaborator

@andrew-farries andrew-farries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 👍

@andrew-farries andrew-farries merged commit 718ecc7 into xataio:main Oct 13, 2024
24 checks passed
@ryanslade
Copy link
Collaborator

Maybe we can move the version extraction into code to more easily add test cases? Doing a simple select version() and then parsing in code may be easier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrew-farries andrew-farries andrew-farries approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pgroll crashes when version includes non-integer characters
3 participants
@songlim327 @ryanslade @andrew-farries