Allow rename-only 'alter-column' operations on unbackfillable columns #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
exekias
reviewed
Apr 22, 2024
andrew-farries
force-pushed
the
support-multiple-alter-column-sub-ops
branch
from
fd2751f
to
0c2e02c
Compare
andrew-farries
force-pushed
the
rename-unbackfillable-columns
branch
from
234fd77
to
c61a2b2
Compare
andrew-farries
force-pushed
the
rename-unbackfillable-columns
branch
from
c61a2b2
to
3104f32
Compare
* When an alter column op requries a backfill, the table must have a primary key on exactly one column. * For rename only alter column ops there is no such restriction.
andrew-farries
force-pushed
the
rename-unbackfillable-columns
branch
from
3104f32
to
9a7c913
Compare
exekias
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow rename-only 'alter column' operations on unbackfillable columns. Rename operations don't require backfills so there is no reason to impose such a restriction.
Fixes #340