Add support for OAuth login #1122
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexis Rico <[email protected]>
🦋 Changeset detectedLatest commit: 6c6cc61 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Signed-off-by: Alexis Rico <[email protected]>
Signed-off-by: Alexis Rico <[email protected]>
|
Your pull request has been published to npm. You can install @xata.io/client by running: Other packages are published like this: To test the CLI, run: |
size-limit report 📦
|
Signed-off-by: Alexis Rico <[email protected]>
Signed-off-by: Alexis Rico <[email protected]>
Signed-off-by: Alexis Rico <[email protected]>
Signed-off-by: Alexis Rico <[email protected]>
Signed-off-by: Alexis Rico <[email protected]>
Signed-off-by: Alexis Rico <[email protected]>
Signed-off-by: Alexis Rico <[email protected]>
Signed-off-by: Alexis Rico <[email protected]>
Signed-off-by: Alexis Rico <[email protected]> Co-authored-by: SferaDev <[email protected]> Co-authored-by: Alexis Rico <[email protected]>
Co-authored-by: eminano <[email protected]>
Signed-off-by: Alexis Rico <[email protected]>
eemmiillyy
previously approved these changes
Nov 27, 2023
| } | ||
|
|
||
| async getXataClient({ profile }: { profile?: Profile } = {}) { | ||
| if (this.#xataClient) return this.#xataClient; | ||
|
|
||
| const { apiKey, host } = profile ?? (await this.getProfile()); | ||
|
|
||
| if (!apiKey) { |
There was a problem hiding this comment.
Should we still check whether the token is an empty string and log that error?
| const currentProfile = await this.getProfile(); | ||
| const domain = web || currentProfile?.web || 'https://app.xata.io'; | ||
|
|
||
| return await loginWithWebUI(domain); |
There was a problem hiding this comment.
We no longer give them the option to create a new API key during login, it's done automatically on login now?
| import { BaseCommand } from '../../base.js'; | ||
| import { readCredentialsDictionary, saveCredentials } from '../../credentials.js'; | ||
|
|
||
| export default class Refresh extends BaseCommand<typeof Refresh> { |
SferaDev
commented
Nov 27, 2023
SferaDev
dismissed
eemmiillyy’s stale review
Dismissing until we test it thoroughly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.