-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use importlib.metadata rather than pkg_resources for version metadata #97
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @norlandrhagen!
What's the motivation for placing the code in a new module rather than __init__.py
?
No strong motivation for separating out version from |
Thanks for the explanation! I think since this is a small amount of code relative to those examples we could minimize the number of modules and keep it in |
Codecov Report
@@ Coverage Diff @@
## main #97 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 5 5
Lines 182 182
Branches 37 33 -4
=========================================
Hits 182 182 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not too familiar with pkg_resources/importlib, but looks ok to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple suggestions so that the metadata imports aren't included in xbatcher's list of public objects.
Co-authored-by: Max Jones <[email protected]>
Co-authored-by: Max Jones <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @norlandrhagen!
Description of proposed changes
PR for Issue #89
Fixes #89
cc @maxrjones