Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update links for GitHub org transfer #88

Merged
merged 3 commits into from
Aug 26, 2022
Merged

Update links for GitHub org transfer #88

merged 3 commits into from
Aug 26, 2022

Conversation

maxrjones
Copy link
Member

Description of proposed changes

Even though GitHub sets up redirects for the transferred repository, it will be more clear to have the links directly point to the xarray-contrib org. This PR updates all such links except in the demo and code of conduct, which require larger updates.

@weiji14
Copy link
Member

weiji14 commented Aug 26, 2022

This PR updates all such links except in the demo and code of conduct, which require larger updates.

Ok with leaving the Code of Conduct untouched since it points to https://github.com/pangeo-data/governance/blob/master/conduct/code_of_conduct.md and there's no equivalent in xarray-contrib. But for demo.ipynb, there's only 3 lines to update, could we not do it in this PR?

Also, small reminder to update the links on https://github.com/conda-forge/xbatcher-feedstock.

@maxrjones
Copy link
Member Author

This PR updates all such links except in the demo and code of conduct, which require larger updates.

Ok with leaving the Code of Conduct untouched since it points to https://github.com/pangeo-data/governance/blob/master/conduct/code_of_conduct.md and there's no equivalent in xarray-contrib. But for demo.ipynb, there's only 3 lines to update, could we not do it in this PR?

I think the demo is rendered from static output stored in the notebook rather than executed when building the docs. So I want to check whether it still works since we've been moving some data around. I'll update the lines if there aren't any other changes required.

Also, small reminder to update the links on https://github.com/conda-forge/xbatcher-feedstock.

Thanks! I'll check on this as well as PyPI and codecov. Do you think it would be helpful to add these common to-do's as a checklist on the issue template for xarray-contrib?

Copy link
Member

@weiji14 weiji14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR updates all such links except in the demo and code of conduct, which require larger updates.

Ok with leaving the Code of Conduct untouched since it points to https://github.com/pangeo-data/governance/blob/master/conduct/code_of_conduct.md and there's no equivalent in xarray-contrib. But for demo.ipynb, there's only 3 lines to update, could we not do it in this PR?

I think the demo is rendered from static output stored in the notebook rather than executed when building the docs. So I want to check whether it still works since we've been moving some data around. I'll update the lines if there aren't any other changes required.

Ah yes, if there's a cache mechanism, then best to be careful. The links should still redirect properly though so it's not urgent.

Also, small reminder to update the links on https://github.com/conda-forge/xbatcher-feedstock.

Thanks! I'll check on this as well as PyPI and codecov. Do you think it would be helpful to add these common to-do's as a checklist on the issue template for xarray-contrib?

Mm, I wouldn't add it to the issue template to be honest (if you mean the transer-repo-to-this-organization template). It's probably better to leave it as a manual thing for maintainers to do 🙂

@maxrjones maxrjones merged commit 31f0d88 into main Aug 26, 2022
@maxrjones maxrjones deleted the org-transfer branch August 26, 2022 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants