Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for community contributions #79

Merged
merged 12 commits into from
Aug 12, 2022

Conversation

maxrjones
Copy link
Member

This PR add components that will enable community contributions:

Closes #32
Closes #44

@codecov
Copy link

codecov bot commented Aug 11, 2022

Codecov Report

Merging #79 (5b817a4) into main (653c3e4) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main       #79   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         4    +1     
  Lines          136       159   +23     
  Branches        32        35    +3     
=========================================
+ Hits           136       159   +23     
Impacted Files Coverage Δ
xbatcher/util/print_versions.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@andersy005 andersy005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me 👍🏽

@andersy005
Copy link
Member

Do we want to relax the codecov requirements for the CI to pass?

@maxrjones
Copy link
Member Author

Thanks for the quick review @andersy005! I'll modify the tests to improve code coverage before merging. I plan to submit another PR to drop 3.7 support and test on 3.10 following NEP 0029, so I think we can ignore that failure.

@maxrjones maxrjones merged commit 213264c into xarray-contrib:main Aug 12, 2022
@maxrjones maxrjones deleted the community-standards branch August 12, 2022 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add github issue/pr templates Add CONTRIBUTING.md
2 participants