Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

100% test coverage #45

Merged
merged 3 commits into from
Nov 19, 2021
Merged

100% test coverage #45

merged 3 commits into from
Nov 19, 2021

Conversation

jhamman
Copy link
Contributor

@jhamman jhamman commented Nov 18, 2021

This PR adds a few tests that get xbatcher to 100% test coverage.

I've also removed the lint check and will active pre-commit.ci in its place.

@codecov
Copy link

codecov bot commented Nov 18, 2021

Codecov Report

Merging #45 (828318d) into main (95d9fe6) will increase coverage by 5.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##             main       #45      +/-   ##
===========================================
+ Coverage   94.93%   100.00%   +5.06%     
===========================================
  Files           3         2       -1     
  Lines          79        77       -2     
  Branches       16        17       +1     
===========================================
+ Hits           75        77       +2     
+ Misses          3         0       -3     
+ Partials        1         0       -1     
Impacted Files Coverage Δ
xbatcher/accessors.py 100.00% <100.00%> (ø)
xbatcher/generators.py 100.00% <100.00%> (+1.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 007bd22...828318d. Read the comment docs.

@jhamman jhamman merged commit cdf0bad into xarray-contrib:main Nov 19, 2021
@jhamman jhamman deleted the coverage branch November 19, 2021 00:21
@maxrjones maxrjones added the maintenance Maintenance tasks label Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants