[pre-commit.ci] pre-commit autoupdate #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pre-commit-ci[bot]](https://avatars.githubusercontent.com/in/68672?s=60&v=4){kind=small}
updates: - [github.com/pre-commit/pre-commit-hooks: v4.4.0 → v4.5.0](pre-commit/pre-commit-hooks@v4.4.0...v4.5.0) - [github.com/psf/black: 23.9.1 → 23.12.1](psf/black@23.9.1...23.12.1) - [github.com/PyCQA/isort: 5.12.0 → 5.13.2](PyCQA/isort@5.12.0...5.13.2) - [github.com/pre-commit/mirrors-prettier: v3.0.3 → v4.0.0-alpha.8](pre-commit/mirrors-prettier@v3.0.3...v4.0.0-alpha.8) - [github.com/pre-commit/mirrors-mypy: v1.5.1 → v1.8.0](pre-commit/mirrors-mypy@v1.5.1...v1.8.0)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #201 +/- ##
=======================================
Coverage 96.25% 96.25%
=======================================
Files 6 6
Lines 347 347
Branches 82 82
=======================================
Hits 334 334
Misses 8 8
Partials 5 5 ☔ View full report in Codecov by Sentry. |
To fix `error: "Mapping[Hashable, int]" has no attribute "mapping" [attr-defined]`, due to incorrect type hint in upstream xarray.
weiji14
reviewed
Jan 1, 2024
| @@ -183,7 +183,7 @@ def validate_batch_dimensions( | |||
|
|
|||
| # Check the names and lengths of the dimensions are equal | |||
| TestCase().assertDictEqual( | |||
| expected_dims, batch.sizes.mapping, msg="Dimension names and/or lengths differ" | |||
| expected_dims, dict(batch.sizes), msg="Dimension names and/or lengths differ" | |||
There was a problem hiding this comment.
Applying this patch to fix error: "Mapping[Hashable, int]" has no attribute "mapping" [attr-defined], due to what might be an incorrect type hint in upstream xarray. The batch.sizes variable should probably have a type hint of xarray.core.utils.Frozen instead?
weiji14
approved these changes
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updates: