Use nbsphinx to execute demo notebook #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #125 +/- ##
=======================================
Coverage 97.97% 97.97%
=======================================
Files 5 5
Lines 198 198
Branches 35 35
=======================================
Hits 194 194
Misses 4 4 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
weiji14
approved these changes
Nov 16, 2022
There was a problem hiding this comment.
Just some minor comments, otherwise good! For reference, readthedocs build at https://readthedocs.org/projects/xbatcher/builds/18654567/ took 4min 13sec.
Co-authored-by: Wei Ji <[email protected]>
Thanks Wei Ji! It'll be interesting to see the speedup after fixing #121. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Automatically execute the demo notebook when building the docs.
Fixes #