Consolidate validation of expected_groups #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcherian
commented
Nov 27, 2022
|
|
||
| if nby > 1 and not isinstance(expected_groups, tuple): # TODO: test for list | ||
| raise ValueError( | ||
| "When grouping by multiple variables, expected_groups must be a tuple " |
There was a problem hiding this comment.
@keewis how is this for a better error message ;) ?
dcherian
force-pushed
the
check-expect-group
branch
from
42e1f57 to
bd6f9b5
Compare
Illviljan
reviewed
Nov 27, 2022
Co-authored-by: Illviljan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref #191