Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix conversion between shapely and cf for lines #493

Merged
merged 2 commits into from
Jan 17, 2024

Conversation

jsignell
Copy link
Contributor

I started working on conversion between shapely and cf for polygons and in that work I realized that I had misunderstood the roles of part_node_count and node_count in #460.

My new understanding is mostly based on: "Example 7.16. Polygons with holes" in https://cfconventions.org/cf-conventions/cf-conventions.html#geometries

Even though that example is for polygons it shows clearly that the part_node_count is meant to denote the edges of the individual shapes and node_count is meant to denote the edges of multi-shapes.

Copy link

codecov bot commented Jan 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f6c8a1f) 85.81% compared to head (ba4a67f) 93.93%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #493      +/-   ##
==========================================
+ Coverage   85.81%   93.93%   +8.11%     
==========================================
  Files          13       12       -1     
  Lines        2284     1714     -570     
  Branches      173        0     -173     
==========================================
- Hits         1960     1610     -350     
+ Misses        294      104     -190     
+ Partials       30        0      -30     
Flag Coverage Δ
mypy ?
unittests 93.93% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dcherian
Copy link
Contributor

Thanks!

@dcherian dcherian merged commit 1fe4359 into xarray-contrib:main Jan 17, 2024
12 checks passed
@jsignell jsignell deleted the lines-fixed branch January 17, 2024 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants