Fix conversion between shapely and cf for lines #493
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started working on conversion between shapely and cf for polygons and in that work I realized that I had misunderstood the roles of
part_node_count
andnode_count
in #460.My new understanding is mostly based on: "Example 7.16. Polygons with holes" in https://cfconventions.org/cf-conventions/cf-conventions.html#geometries
Even though that example is for polygons it shows clearly that the
part_node_count
is meant to denote the edges of the individual shapes andnode_count
is meant to denote the edges of multi-shapes.