CA-399172: fix potential crash in Uri.of_string #696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using Lazy from a multithreaded program should raise Lazy.Undefined. However due to bugs in the OCaml runtime this was actually crashing. Update to angstrom 0.16.1 which no longer uses Lazy and avoids this crash. This was initially discovered: * mirage/ocaml-uri#178 Fixed in Angstrom: * inhabitedtype/angstrom#229 Runtime bug reported with potential fix from maintainers: * ocaml/ocaml#13430 * ocaml/ocaml#13434 There are various other usages of Lazy, but I couldn't get those to crash yet, so lets fix the known crash for now, and audit/fix the rest next. Signed-off-by: Edwin Török <[email protected]>
psafont
reviewed
Sep 13, 2024
lindig
approved these changes
Sep 13, 2024
|
Hmm I didn't click the button, but github says I did |
|
The CI seems to be passing now though |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using Lazy from a multithreaded program should raise Lazy.Undefined. However due to bugs in the OCaml runtime this was actually crashing.
Update to angstrom 0.16.1 which no longer uses Lazy and avoids this crash.
This was initially discovered:
Fixed in Angstrom:
Runtime bug reported with potential fix from maintainers:
There are various other usages of Lazy, but I couldn't get those to crash yet, so lets fix the known crash for now, and audit/fix the rest next.