CA-404591 - rrd: Do not lose precision when converting floats to strings #6238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lastupdate field in the XML RRD blob file, in particular, was getting truncated floats representing the number of seconds, which loses A LOT of precision, meaning RRDs could not be checked to have been produced with the 5-second frequency. Signed-off-by: Andrii Sultanov <[email protected]>
|
This, together with an update to xenrt code, passed the faulty test (4198186) |
|
On the other hand, this change makes the |
psafont
approved these changes
Jan 17, 2025
freddy77
approved these changes
Jan 17, 2025
robhoes
approved these changes
Jan 17, 2025
edwintorok
approved these changes
Jan 17, 2025
There was a problem hiding this comment.
In some cases 16g or 17g might be needed, but we don't deal with values quite so precise in RRDs.
15g is probably a good compromise: 17g would make the output even bigger unnecessarily.
A more compact form might be to use '%h' and this would fully preserve all the bits in the float, but it wouldn't be compatible with JSON.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lastupdatefield in the XML RRD blob file, in particular, was getting truncated floats representing the number of seconds, which loses A LOT of precision, meaning RRDs could not be checked to have been produced with the 5-second frequency.