Skip to content
This repository has been archived by the owner on Dec 10, 2024. It is now read-only.

add missing fields in Note struct #1866

Merged
merged 2 commits into from
Jan 17, 2024
Merged

add missing fields in Note struct #1866

merged 2 commits into from
Jan 17, 2024

Conversation

cenkalti
Copy link
Contributor

@cenkalti cenkalti commented Jan 17, 2024

https://docs.gitlab.com/ee/api/notes.html#issues

Example issue note (comment) from my GitLab instance:

{
  "id": 3,
  "type": null,
  "body": "Comment 2",
  "attachment": null,
  "author": {
    "id": 1,
    "username": "root",
    "name": "Administrator",
    "state": "active",
    "locked": false,
    "avatar_url": "https://secure.gravatar.com/avatar/e64c7d89f26bd1972efa854d13d7dd61?s=80&d=identicon",
    "web_url": "https://gitlab.example.com/root"
  },
  "created_at": "2024-01-15T22:32:55.785Z",
  "updated_at": "2024-01-15T22:32:55.785Z",
  "system": false,
  "noteable_id": 3,
  "noteable_type": "Issue",
  "project_id": 4,
  "resolvable": false,
  "confidential": false,
  "internal": false,
  "noteable_iid": 1,
  "commands_changes": {}
}

Copy link
Member

@svanharmelen svanharmelen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cenkalti 👍🏻

@svanharmelen svanharmelen merged commit 63caa48 into xanzy:main Jan 17, 2024
3 checks passed
@cenkalti
Copy link
Contributor Author

@svanharmelen thanks for swift response. Is it possible for you to release a new tag version?

@cenkalti cenkalti deleted the notes branch January 17, 2024 19:08
@svanharmelen
Copy link
Member

Released v0.96.0

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants