Skip to content
This repository has been archived by the owner on Dec 10, 2024. It is now read-only.

Correct Json marshaling for labels of issues #1840

Merged

Conversation

tkschmidt
Copy link
Contributor

Labels for issues should be marshalled to a list of strings instead of single (comma-seperated) string. This is according to https://docs.gitlab.com/ee/api/issues.html (22-11-2023)

Labels for issues should be marshalled to a list of strings instead of single (comma-seperated) string. This is according to https://docs.gitlab.com/ee/api/issues.html (22-11-2023)
Copy link
Member

@svanharmelen svanharmelen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While more involved and backwards incompatible, I think this is the only "correct" solution for this one...

@svanharmelen svanharmelen merged commit db87505 into xanzy:main Dec 9, 2023
3 checks passed
@aaronjheng
Copy link

Why was Description field from CreateMergeRequestOptions changed to *LabelOptions?

@svanharmelen
Copy link
Member

Thats a mistake... Thanks for spotting it, will change it in a bit!

@svanharmelen
Copy link
Member

Fixed in v0.95.1

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants