Skip to content
This repository has been archived by the owner on Dec 10, 2024. It is now read-only.

Add summary support in AddSpentTimeOptions #1818

Merged
merged 1 commit into from
Oct 6, 2023

Conversation

airclovis
Copy link

@airclovis airclovis commented Oct 5, 2023

Goal

This PR is adding a summary field in the AddSpentTimeOptions structure.

This structure is used to call the add spent API endpoints for merge requests and issues.

Today we can only pass the duration of the time spent when calling gitlab API, however the 2 endpoints also accept a summary optional field (see merge request and issues).

Adding this new field in the structure will allow users to set a specific summary value while calling gitlab API.

This commit is adding a `summary` field in the `AddSpentTimeOptions`
structure.

This structure is used to call the add spent API endpoints for merge
requests and issues. Today we can only pass the duration of the time
spent when calling gitlab API, however the 2 endpoints also accept a
`summary` optional field.

Adding this new field in the structure will allow users to set a
specific `summary` value while calling gitlab API.

[1]: https://docs.gitlab.com/ee/api/merge_requests.html#add-spent-time-for-a-merge-request
[2]: https://docs.gitlab.com/ee/api/issues.html#add-spent-time-for-an-issue
Copy link
Member

@svanharmelen svanharmelen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @airclovis! LGTM 👍🏻

@svanharmelen svanharmelen merged commit 99e75d5 into xanzy:master Oct 6, 2023
3 checks passed
@stang
Copy link

stang commented Oct 9, 2023

Thank @airclovis and @svanharmelen.

We're relying on this library and were exactly looking for this feature. I saw the PR has been merged. @svanharmelen do you plan to push a new release anytime soon? 🙏

@svanharmelen
Copy link
Member

Tagged v0.93.1

@stang
Copy link

stang commented Oct 9, 2023

Awesome! Thank you for your prompt reaction!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants