This repository has been archived by the owner on Dec 10, 2024. It is now read-only.
Make sure response is fully consumed #1813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fully consumes a response body. I have learned through some other experiences that this is important to do in Go. This is especially useful if
nilis provided asv, because then response body is just closed. But also when JSON decoder does not decode all data (and there is some extra bytes after the decoded JSON response) - JSON decoder does not necessary consume full input, just enough thatvis decoded. Any errors returned byio.Copyare ignored on purpose.See similar thing in go-github library: google/go-github#317