Merge pull request #2062 from xanzy/metadata-proxy

Implement `externalK8sProxyUrl` field in Metadata API
xanzy · Nov 18, 2024 · 912f9bf · 912f9bf
2 parents 24eba26 + 29c7d05
commit 912f9bf
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 10 deletions.
diff --git a/metadata.go b/metadata.go
@@ -33,9 +33,10 @@ type Metadata struct {
 	Version  string `json:"version"`
 	Revision string `json:"revision"`
 	KAS      struct {
-		Enabled     bool   `json:"enabled"`
-		ExternalURL string `json:"externalUrl"`
-		Version     string `json:"version"`
+		Enabled             bool   `json:"enabled"`
+		ExternalURL         string `json:"externalUrl"`
+		ExternalK8SProxyURL string `json:"externalK8sProxyUrl"`
+		Version             string `json:"version"`
 	} `json:"kas"`
 	Enterprise bool `json:"enterprise"`
 }

diff --git a/metadata_test.go b/metadata_test.go
@@ -35,7 +35,8 @@ func TestGetMetadata(t *testing.T) {
         "enterprise": true,
         "kas": {
           "enabled": true,
-          "externalUrl": "wss://kas.gitlab.com",
+          "externalUrl": "wss://kas.gitlab.example.com",
+          "externalK8sProxyUrl": "https://kas.gitlab.example.com/k8s-proxy",
           "version": "15.6.0-rc2"
         }
       }`)
@@ -48,13 +49,15 @@ func TestGetMetadata(t *testing.T) {
 
 	want := &Metadata{
 		Version: "15.6.0-pre", Revision: "016e8d8bdc3", KAS: struct {
-			Enabled     bool   `json:"enabled"`
-			ExternalURL string `json:"externalUrl"`
-			Version     string `json:"version"`
+			Enabled             bool   `json:"enabled"`
+			ExternalURL         string `json:"externalUrl"`
+			ExternalK8SProxyURL string `json:"externalK8sProxyUrl"`
+			Version             string `json:"version"`
 		}{
-			Enabled:     true,
-			ExternalURL: "wss://kas.gitlab.com",
-			Version:     "15.6.0-rc2",
+			Enabled:             true,
+			ExternalURL:         "wss://kas.gitlab.example.com",
+			ExternalK8SProxyURL: "https://kas.gitlab.example.com/k8s-proxy",
+			Version:             "15.6.0-rc2",
 		},
 		Enterprise: true,
 	}