Added missing fields for flexibleRollout feature flag strategy

xanzy · Dec 6, 2023 · 586ab88 · 586ab88
1 parent 3e35f87
commit 586ab88
Show file tree

Hide file tree

Showing 3 changed files with 36 additions and 0 deletions.
diff --git a/project_feature_flags.go b/project_feature_flags.go
@@ -53,6 +53,12 @@ type ProjectFeatureFlagStrategyParameter struct {
 	GroupID    string `json:"groupId,omitempty"`
 	UserIDs    string `json:"userIds,omitempty"`
 	Percentage string `json:"percentage,omitempty"`
+
+	// Following fields aren't documented in Gitlab API docs,
+	// but are present in Gitlab API since 13.5.
+	// Docs: https://docs.getunleash.io/reference/activation-strategies#gradual-rollout
+	Rollout    string `json:"rollout,omitempty"`
+	Stickiness string `json:"stickiness,omitempty"`
 }
 
 func (i ProjectFeatureFlag) String() string {

diff --git a/project_feature_flags_test.go b/project_feature_flags_test.go
@@ -117,6 +117,21 @@ func TestGetProjectFeatureFlag(t *testing.T) {
 					},
 				},
 			},
+			{
+				ID:   24,
+				Name: "flexibleRollout",
+				Parameters: &ProjectFeatureFlagStrategyParameter{
+					GroupID:    "default",
+					Rollout:    "50",
+					Stickiness: "default",
+				},
+				Scopes: []*ProjectFeatureFlagScope{
+					{
+						ID:               52,
+						EnvironmentScope: "*",
+					},
+				},
+			},
 		},
 	}
 

diff --git a/testdata/get_project_feature_flag.json b/testdata/get_project_feature_flag.json
@@ -17,6 +17,21 @@
           "environment_scope": "production"
         }
       ]
+    },
+    {
+      "id": 24,
+      "name": "flexibleRollout",
+      "parameters": {
+        "groupId": "default",
+        "rollout": "50",
+        "stickiness": "default"
+      },
+      "scopes": [
+        {
+          "id": 52,
+          "environment_scope": "*"
+        }
+      ]
     }
   ]
 }