-
Notifications
You must be signed in to change notification settings - Fork 514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NearbyInteraction][Xcode12] Add manual binding for NINearbyObjectDirectionNotAvailable #9346
Merged
whitneyschmidt
merged 12 commits into
xamarin:xcode12
from
whitneyschmidt:nearbyinteraction
Aug 12, 2020
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
d57265a
nichanges + apiclassptrtest debugging code
whitneyschmidt 23ec667
actually add ni bindings
whitneyschmidt 281fb3f
updates to fix intro failure
whitneyschmidt d822bb3
link to maccore issue
whitneyschmidt 0d5b796
updates for nearbyinteraction manual code + fix NIErrorDomain binding
whitneyschmidt d6a9bbe
merge xcode12
whitneyschmidt ad09cdd
remove noise
whitneyschmidt 9889c07
remove .ignore
whitneyschmidt d523686
fix typos
whitneyschmidt 0074fe0
add unit test, fix up seb suggestions
whitneyschmidt ab47613
fix Assert to avoid allocating string every time
whitneyschmidt 0904e2a
fix test failures by wrapping with __IOS__, clean up version check
whitneyschmidt File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,41 @@ | ||
// | ||
// NearbyInteraction manual bindings | ||
// | ||
// Authors: | ||
// Whitney Schmidt <[email protected]> | ||
// | ||
// Copyright 2020 Microsoft Inc. | ||
// | ||
|
||
using System; | ||
using System.Runtime.InteropServices; | ||
|
||
using CoreFoundation; | ||
using Foundation; | ||
using ObjCRuntime; | ||
using Vector3 = global::OpenTK.Vector3; | ||
|
||
#if __IOS__ | ||
namespace NearbyInteraction { | ||
partial class NINearbyObject | ||
{ | ||
static Vector3? _DirectionNotAvailable; | ||
|
||
// TODO: https://github.com/xamarin/maccore/issues/2274 | ||
// We do not have generator support to trampoline Vector3 -> vector_float3 for Fields | ||
[Field ("NINearbyObjectDirectionNotAvailable", "NearbyInteraction")] | ||
public static Vector3 DirectionNotAvailable { | ||
get { | ||
if (_DirectionNotAvailable == null) { | ||
unsafe { | ||
Vector3 *pointer = (Vector3 *) Dlfcn.GetIndirect (Libraries.NearbyInteraction.Handle, "NINearbyObjectDirectionNotAvailable"); | ||
_DirectionNotAvailable = *pointer; | ||
} | ||
} | ||
return (Vector3)_DirectionNotAvailable; | ||
} | ||
} | ||
} | ||
|
||
} | ||
#endif //__IOS__ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
36 changes: 36 additions & 0 deletions
36
tests/monotouch-test/NearbyInteraction/NINearbyObjectTest.cs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,36 @@ | ||
// Copyright 2020 Microsoft Corp. | ||
|
||
#if __IOS__ | ||
|
||
using System; | ||
using Foundation; | ||
using ObjCRuntime; | ||
using NearbyInteraction; | ||
using NUnit.Framework; | ||
using OpenTK; | ||
|
||
namespace MonoTouchFixtures.NearbyInteraction { | ||
|
||
[TestFixture] | ||
[Preserve (AllMembers = true)] | ||
public class NINearbyObjectTest { | ||
|
||
[Test] | ||
public void DirectionNotAvailable () | ||
{ | ||
TestRuntime.AssertXcodeVersion (12, 0); | ||
|
||
Vector3 vect = NINearbyObject.DirectionNotAvailable; | ||
|
||
unsafe { | ||
Vector3* v = &vect; | ||
byte* ptr = (byte*) v; | ||
byte zero = 0; | ||
for (var i = 0; i < sizeof (Vector3); i++) | ||
Assert.That (ptr [i], Is.EqualTo (zero), $"Position {i}"); | ||
} | ||
} | ||
} | ||
} | ||
|
||
#endif // __IOS__ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor: it's not
Inc.
it'sCorp.
;-)