Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Don't Link] Update TableViewSourceTest's assert message #2385

Merged

Conversation

VincentDondain
Copy link
Contributor

- Remove obsolete and confusing warning in `UITableViewSource`.
  See xamarin/maccore@5999181
  where UITableViewController started conforming to UITableViewDataSource, UITableViewDelegate
  removing the need to add all methods to UITableViewController.
@monojenkins
Copy link
Collaborator

Build failure

@VincentDondain
Copy link
Contributor Author

Unrelated test failure: https://bugzilla.xamarin.com/show_bug.cgi?id=58394

@VincentDondain VincentDondain merged commit 336087f into xamarin:master Aug 1, 2017
@VincentDondain VincentDondain deleted the update-tableviewsourcetest branch August 1, 2017 16:00
spouliot pushed a commit to spouliot/xamarin-macios that referenced this pull request Feb 9, 2021
bump maccore for dependencies updates

New commits in xamarin/maccore:

* xamarin/maccore@c50173e637 Remove dependency on XmlDocSync repo/tools (xamarin#2392)
* xamarin/maccore@9427bd123a Update NuGet.config to enforce a single feed (xamarin#2373)
* xamarin/maccore@146b36ed00 Keychain file computed incorrectly on Big Sur (xamarin#2388) (xamarin#2390)
* xamarin/maccore@4080d06db9 [mlaunch] Fix dependencies for Xcode 12.5 beta 1 (xamarin#2385)

Diff: https://github.com/xamarin/maccore/compare/428964bf32f06862eb4209129c6fb5b882c3b9be..c50173e637f7c10066f81dd8d130035f5672611a
spouliot added a commit that referenced this pull request Feb 10, 2021
bump maccore for dependencies updates

New commits in xamarin/maccore:

* xamarin/maccore@c50173e637 Remove dependency on XmlDocSync repo/tools (#2392)
* xamarin/maccore@9427bd123a Update NuGet.config to enforce a single feed (#2373)
* xamarin/maccore@146b36ed00 Keychain file computed incorrectly on Big Sur (#2388) (#2390)
* xamarin/maccore@4080d06db9 [mlaunch] Fix dependencies for Xcode 12.5 beta 1 (#2385)

Diff: https://github.com/xamarin/maccore/compare/428964bf32f06862eb4209129c6fb5b882c3b9be..c50173e637f7c10066f81dd8d130035f5672611a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants