Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[msbuild] Port the OptimizeImage task to subclass XamarinTask. #21618

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[msbuild] Port the OptimizeImage task to subclass XamarinTask. #21618

wants to merge 1 commit into from
+79 −54

Commits on Nov 13, 2024

  1. [msbuild] Port the OptimizeImage task to subclass XamarinTask. 

    This has a few advantages:

* We simplify and unify more of our code.
* We have more control over the error reporting / logging behavior.
* We can optimize images in parallel.

Additionally:

* Use 'xcrun' to invoke 'pngcrush' (partial fix for #3931).
* Allow for overriding the path to the command-line tool in question.
* Add support for cancellation.
* Fix nullability.
    @rolfbjarne
    rolfbjarne committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    850ba50 View commit details
    Browse the repository at this point in the history