Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[StoreKit] Bind AppStore.requestReview. Fixes #21410. #21441

Merged
merged 4 commits into from
Oct 16, 2024
Merged

[StoreKit] Bind AppStore.requestReview. Fixes #21410. #21441

merged 4 commits into from
Oct 16, 2024

Commits on Oct 15, 2024

  1. [StoreKit] Bind AppStore.requestReview. Fixes #21410. 

    The existing Objective-C class to request an App Store review (SKStoreReviewController)
is deprecated in Xcode 16+, and it doesn't even work on the corresponding OS versions.

The replacement API is Swift-only, but luckily it's a very simple API (just a static
method), so it's possible to bind it manually.

This required a few other changes/improvements:

* Add support for Swift code in our runtime.

* Just to keep the changes to a minimum, bump the min OS version for legacy code
  to match the .NET min OS versions. This is because our build logic uses the legacy
  min versions when compiling native code (a more involved fix would be to update
  all the build logic to build native code to use the .NET min OS versions, but that's
  not the point of this PR, so I took the easy route).

I've tested the method locally, and it seems to work fine, but I've still marked
it as experimental for now. There are no unit tests because calling the method will
put up a dialog, which won't work correctly in unit tests.

Fixes #21410.
    @rolfbjarne
    rolfbjarne committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    7b85986 View commit details
    Browse the repository at this point in the history

  2. Add documentation

    @rolfbjarne
    rolfbjarne committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    f1c46f4 View commit details
    Browse the repository at this point in the history

  3. No default ctor.

    @rolfbjarne
    rolfbjarne committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    1b6628f View commit details
    Browse the repository at this point in the history

  4. Misc test fixes.

    @rolfbjarne
    rolfbjarne committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    bfb8635 View commit details
    Browse the repository at this point in the history