[GameController] Add missing API for XCode15. Fixes #15725 #19708

mandel-macaque · 2023-12-22T22:57:34Z

This PR adds the missing bindings and fixes #15725. What the issue reported is incorrect, the problem with the API is that it uses Swift enumerators that have a String RawValue. The way to fix this in our bindings is to use the string values that are PRESENT in the headers.

This PR adds the missing bindings and fixes xamarin#15725. What the issue reported is incorrect, the problem with the API is that it uses Swift enumerators that have a String RawValue. The way to fix this in our bindings is to use the string values that are **PRESENT** in the headers.

src/gamecontroller.cs

github-actions · 2023-12-22T23:00:52Z

⚠️ Your code has been reformatted. ⚠️

If this is not desired, add the actions-disable-autoformat label, and revert the reformatting commit.

If files unrelated to your change were modified, try reverting the reformatting commit + merging with the target branch (and push those changes).

rolfbjarne

I think this also needs tests, even for a sample of the generated bindings, because the API is somewhat uncommon.

tests/introspection/iOS/iOSApiProtocolTest.cs

src/gamecontroller.cs

src/GameController/GCPhysicalInputElementCollection_2.cs

rolfbjarne · 2024-01-02T11:02:08Z

src/GameController/GCPhysicalInputElementCollection_2.cs

+		public NSEnumerator<IGCPhysicalInputElement> ElementEnumerator
+			=> Runtime.GetNSObject<NSEnumerator<IGCPhysicalInputElement>> (_ElementEnumerator)!;


This should be a property, not a field.

This is a property, notice the '=>' and not a '='

Ah - this is exactly why Sebastien said to not use => for properties, it's a very small difference from fields (just a single character), and can end up confusing.

It's also public and not private which is the better indicator for me personally.

Co-authored-by: Rolf Bjarne Kvinge <[email protected]>

mandel-macaque · 2024-01-02T16:27:19Z

I think this also needs tests, even for a sample of the generated bindings, because the API is somewhat uncommon.

The issue with this API is that in most cases it needs a controller to test. I have an xbox controller which I can use to write a sample, but adding that in the CI will be problematic.

I have added all the suggested changes. Shall we do a sample? /cc @dalexsoto

dalexsoto

Yeah I have to agree with @rolfbjarne and my old (younger?) self, this ideally requires a sample.

vs-mobiletools-engineering-service2 · 2024-01-05T14:38:54Z

💻 [CI Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻

✅ All tests on macOS M1 - Mac Big Sur (11.5) passed.

Pipeline on Agent
Hash: [PR build]

vs-mobiletools-engineering-service2 · 2024-01-05T14:41:24Z

❌ [CI Build] Tests on macOS M1 - Mac Ventura (13.0) failed ❌

Failed tests are:

introspection

Pipeline on Agent
Hash: [PR build]

vs-mobiletools-engineering-service2 · 2024-01-05T14:58:28Z

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent
Hash: [PR build]

vs-mobiletools-engineering-service2 · 2024-01-05T14:59:22Z

💻 [CI Build] Windows Integration Tests passed 💻

✅ All Windows Integration Tests passed.

Pipeline on Agent
Hash: f26a018341dc232a33e3a66e6f68a3138c27f91e [PR build]

vs-mobiletools-engineering-service2 · 2024-01-05T15:33:02Z

✅ API diff for current PR / commit

Legacy Xamarin (No breaking changes)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
~~watchOS~~ (no change detected)
macOS: vsdrops gist (No breaking changes)

.NET (No breaking changes)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
MacCatalyst: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)

✅ API diff vs stable

Legacy Xamarin (No breaking changes)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
watchOS: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)

.NET (No breaking changes)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
MacCatalyst: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)
Microsoft.iOS vs Microsoft.MacCatalyst: vsdrops gist

Legacy Xamarin (stable) vs .NET

iOS: vsdrops gist
tvOS: vsdrops gist
macOS: vsdrops gist

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: f26a018341dc232a33e3a66e6f68a3138c27f91e [PR build]

vs-mobiletools-engineering-service2 · 2024-01-05T17:27:12Z

🔥 [CI Build] Test results 🔥

Test results

❌ Tests failed on VSTS: simulator tests

1 tests crashed, 4 tests failed, 229 tests passed.

Failures

❌ introspection tests

4 tests failed, 4 tests passed.

introspection/Mac Catalyst [dotnet]/Debug [dotnet]: Failed (Test run failed.
Tests run: 40 Passed: 38 Inconclusive: 0 Failed: 1 Ignored: 1)
introspection/Mac Modern/Debug: Failed (Test run failed.
Tests run: 37 Passed: 35 Inconclusive: 0 Failed: 1 Ignored: 1)
introspection/iOS Unified 64-bits - simulator/Debug [dotnet]: Failed
introspection/tvOS - simulator/Debug [dotnet]: Failed

Html Report (VSDrops) Download

❌ msbuild tests

🔥 Failed catastrophically on VSTS: simulator tests - msbuild (no summary found).

Html Report (VSDrops) Download

Successes

✅ bcl: All 69 tests passed. Html Report (VSDrops) Download
✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests: All 1 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ framework: All 8 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 7 tests passed. Html Report (VSDrops) Download
✅ install_source: All 1 tests passed. Html Report (VSDrops) Download
✅ linker: All 65 tests passed. Html Report (VSDrops) Download
✅ mac_binding_project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download
✅ mononative: All 6 tests passed. Html Report (VSDrops) Download
✅ monotouch: All 41 tests passed. Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: f26a018341dc232a33e3a66e6f68a3138c27f91e [PR build]

mcumming

Possibly use https://appleinsider.com/articles/21/03/22/apple-adds-controller-emulation-to-macos-big-sur-113-beta for tests?

mcumming · 2024-01-08T16:43:29Z

src/GameController/GCPhysicalInputElementCollection_2.cs

+		public NSEnumerator<IGCPhysicalInputElement> ElementEnumerator
+			=> Runtime.GetNSObject<NSEnumerator<IGCPhysicalInputElement>> (_ElementEnumerator)!;


It's also public and not private which is the better indicator for me personally.

mcumming · 2024-01-08T16:44:53Z

tests/introspection/Mac/MacApiCtorInitTest.cs

@@ -181,6 +181,9 @@ protected override bool Skip (Type type)
 				if (Mac.CheckSystemVersion (10, 15))
 					return true;
 				break;
+			case "GameController.GCPhysicalInputSource":


Should these use constants, enumerations, or nameof?

mcumming · 2024-01-08T16:46:14Z

tests/introspection/Mac/MacApiProtocolTest.cs

 			case "ASAuthorizationProviderExtensionRegistrationHandler":
 				return true;
+			case "GCPhysicalInputSource":
+				return true;


Should the case values be using constants, enumerations, or nameof?

mandel-macaque added 2 commits December 22, 2023 17:55

Merge branch 'main' into net8.0-xcode15-gamecontroller

1514090

mandel-macaque commented Dec 22, 2023

View reviewed changes

src/gamecontroller.cs Outdated Show resolved Hide resolved

mandel-macaque and others added 2 commits December 22, 2023 17:59

Missing ','

4c73e06

Auto-format source code

087db04

This comment has been minimized.

Sign in to view

rolfbjarne requested changes Jan 2, 2024

View reviewed changes

Apply suggestions from code review

f2d784c

Co-authored-by: Rolf Bjarne Kvinge <[email protected]>

mandel-macaque added 2 commits January 2, 2024 11:27

Merge branch 'main' into net8.0-xcode15-gamecontroller

7457c41

Fix code after taking contributions in the PR review.

b7ad3ac

This comment has been minimized.

Sign in to view

Merge branch 'main' into net8.0-xcode15-gamecontroller

b44cdc7

dalexsoto requested changes Jan 3, 2024

View reviewed changes

This comment has been minimized.

Sign in to view

Merge branch 'main' into net8.0-xcode15-gamecontroller

f26a018

mcumming reviewed Jan 8, 2024

View reviewed changes

		public NSEnumerator<IGCPhysicalInputElement> ElementEnumerator
		=> Runtime.GetNSObject<NSEnumerator<IGCPhysicalInputElement>> (_ElementEnumerator)!;

[GameController] Add missing API for XCode15. Fixes #15725 #19708

Are you sure you want to change the base?

[GameController] Add missing API for XCode15. Fixes #15725 #19708

Conversation

mandel-macaque commented Dec 22, 2023

github-actions bot commented Dec 22, 2023

⚠️ Your code has been reformatted. ⚠️

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

rolfbjarne left a comment

Choose a reason for hiding this comment

rolfbjarne Jan 2, 2024

Choose a reason for hiding this comment

mandel-macaque Jan 2, 2024

Choose a reason for hiding this comment

rolfbjarne Jan 2, 2024

Choose a reason for hiding this comment

mcumming Jan 8, 2024

Choose a reason for hiding this comment

mandel-macaque commented Jan 2, 2024

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

dalexsoto left a comment

Choose a reason for hiding this comment

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Jan 5, 2024

💻 [CI Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻

vs-mobiletools-engineering-service2 commented Jan 5, 2024

❌ [CI Build] Tests on macOS M1 - Mac Ventura (13.0) failed ❌

vs-mobiletools-engineering-service2 commented Jan 5, 2024

📚 [PR Build] Artifacts 📚

Packages generated

vs-mobiletools-engineering-service2 commented Jan 5, 2024

💻 [CI Build] Windows Integration Tests passed 💻

vs-mobiletools-engineering-service2 commented Jan 5, 2024

✅ API diff for current PR / commit

✅ API diff vs stable

ℹ️ Generator diff

vs-mobiletools-engineering-service2 commented Jan 5, 2024

🔥 [CI Build] Test results 🔥

Test results

Failures

❌ introspection tests

❌ msbuild tests

Successes

mcumming left a comment

Choose a reason for hiding this comment

mcumming Jan 8, 2024

Choose a reason for hiding this comment

mcumming Jan 8, 2024

Choose a reason for hiding this comment

mcumming Jan 8, 2024

Choose a reason for hiding this comment