[Foundation] Remove support for '[NSAttributedString initWithFileURL:options:documentAttributes:error:]'. #16787
Conversation
…options:documentAttributes:error:]'. The 'initWithFileURL:options:documentAttributes:error:' was deprecated in iOS 9, and a new alternative (initWithURL:options:documentAttributes:error:) was added. At the time, we implemented automatic detection of the current OS, and would choose one version or the other depending on which was available. We won't support anything below iOS 9 anymore, which means that keeping the backwards-compatible constructor is useless, so just remove the corresponding code and expose the new alternative directly. On another note, this constructor uses a 'ref NSError' argument instead of an 'out NSError' on mobile platforms (likely due to the generator not having proper 'out' parameter support when this constructor was implemented), so improve to use 'out' parameters in XAMCORE_5_0 (and macOS, where it already uses 'out' parameters). Ref: xamarin#15216
📚 [PR Build] Artifacts 📚Artifacts were not provided. Pipeline on Agent XAMBOT-1101.Monterey' |
✅ API diff for current PR / commitLegacy Xamarin (No breaking changes)
NET (empty diffs)
❗ API diff vs stable (Breaking changes)Legacy Xamarin (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:).NET (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻✅ All tests on macOS M1 - Mac Big Sur (11.5) passed. Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
🚀 [CI Build] Test results 🚀Test results✅ All tests passed on VSTS: simulator tests. 🎉 All 223 tests passed 🎉 Tests counts✅ bcl: All 69 tests passed. [attempt 2] Html Report (VSDrops) Download Pipeline on Agent |
rolfbjarne
deleted the
nsattributedstring-remove-old-constructor-support
branch
The 'initWithFileURL:options:documentAttributes:error:' was deprecated in iOS
9, and a new alternative (initWithURL:options:documentAttributes:error:) was
added. At the time, we implemented automatic detection of the current OS, and
would choose one version or the other depending on which was available.
We won't support anything below iOS 9 anymore, which means that keeping the
backwards-compatible constructor is useless, so just remove the corresponding
code and expose the new alternative directly.
On another note, this constructor uses a 'ref NSError' argument instead of an
'out NSError' on mobile platforms (likely due to the generator not having
proper 'out' parameter support when this constructor was implemented), so
improve to use 'out' parameters in XAMCORE_5_0 (and macOS, where it already
uses 'out' parameters).
Ref: #15216