Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[autoformat] Update to cope with breaking changes in actions/github-script. #16240

Merged

Conversation

rolfbjarne
Copy link
Member

actions/github-script was recently updated from 3.1.0 to 6.3.1 (69de14c), but unfortunately there were breaking changes:

This would manifest as:

TypeError: Cannot read properties of undefined (reading 'listWorkflowRunArtifacts')
Error: Unhandled error: TypeError: Cannot read properties of undefined (reading 'listWorkflowRunArtifacts')
    at eval (eval at callAsyncFunction (/home/runner/work/_actions/actions/github-script/v6.3.1/dist/index.js:13340:16), <anonymous>:3:38)
    at callAsyncFunction (/home/runner/work/_actions/actions/github-script/v6.3.1/dist/index.js:13341:12)
    at main (/home/runner/work/_actions/actions/github-script/v6.3.1/dist/index.js:13436:26)
    at Module.858 (/home/runner/work/_actions/actions/github-script/v6.3.1/dist/index.js:13413:1)
    at __webpack_require__ (/home/runner/work/_actions/actions/github-script/v6.3.1/dist/index.js:24:31)
    at startup (/home/runner/work/_actions/actions/github-script/v6.3.1/dist/index.js:43:19)
    at /home/runner/work/_actions/actions/github-script/v6.3.1/dist/index.js:49:18
    at Object.<anonymous> (/home/runner/work/_actions/actions/github-script/v6.3.1/dist/index.js:52:10)
    at Module._compile (node:internal/modules/cjs/loader:1101:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1153:10)

So update our code to to use the new way to do things.

…cript.

actions/github-script was recently updated from 3.1.0 to 6.3.1 (69de14c), but unfortunately there were breaking changes:

* https://github.com/actions/github-script#breaking-changes
* actions/github-script#242 (comment)

This would manifest as:

    TypeError: Cannot read properties of undefined (reading 'listWorkflowRunArtifacts')
    Error: Unhandled error: TypeError: Cannot read properties of undefined (reading 'listWorkflowRunArtifacts')
        at eval (eval at callAsyncFunction (/home/runner/work/_actions/actions/github-script/v6.3.1/dist/index.js:13340:16), <anonymous>:3:38)
        at callAsyncFunction (/home/runner/work/_actions/actions/github-script/v6.3.1/dist/index.js:13341:12)
        at main (/home/runner/work/_actions/actions/github-script/v6.3.1/dist/index.js:13436:26)
        at Module.858 (/home/runner/work/_actions/actions/github-script/v6.3.1/dist/index.js:13413:1)
        at __webpack_require__ (/home/runner/work/_actions/actions/github-script/v6.3.1/dist/index.js:24:31)
        at startup (/home/runner/work/_actions/actions/github-script/v6.3.1/dist/index.js:43:19)
        at /home/runner/work/_actions/actions/github-script/v6.3.1/dist/index.js:49:18
        at Object.<anonymous> (/home/runner/work/_actions/actions/github-script/v6.3.1/dist/index.js:52:10)
        at Module._compile (node:internal/modules/cjs/loader:1101:14)
        at Object.Module._extensions..js (node:internal/modules/cjs/loader:1153:10)

So update our code to to use the new way to do things.
@rolfbjarne rolfbjarne added the not-notes-worthy Ignore for release notes label Oct 5, 2022
@rolfbjarne rolfbjarne merged commit 890c9b7 into xamarin:main Oct 5, 2022
@rolfbjarne rolfbjarne deleted the autoformat-fix-listWorkflowRunArtifacts branch October 5, 2022 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
not-notes-worthy Ignore for release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants