[tools] Don't call mono_marshal_ilgen_init in .NET.

[rolfbjarne]

Ref: dotnet/runtime#74628.

[dalexsoto]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[chamons]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[lambdageek]

I'm now a little bit concerned that this was the wrong fix.
When using the interpreter you link the mono-ilgen.a library and I think in that case the call to mono_marshal_ilgen_init has to stay. So maybe we need the runtime fix dotnet/runtime#74658 after all

xamarin-macios/tools/mtouch/Target.mtouch.cs

Line 1530 in 028afc2

string libilgen = Path.Combine (libmonodir, "libmono-ilgen.a");

[chamons]

Adding do-not-merge until runtime folks give us a final 👍 / 👎 on the fix - @lambdageek @steveisok

FYI @dalexsoto

[lambdageek]

just to record our thinking. we think 👍 because it unblocks key scenarios (hot reload; other uses of the interpreter) but it is not 100% the correct fix because it seems like there are circumstances where mono_marshal_ilgen_inti does real work (I am not 100% clear on what scenario tht might be - something with the interpreter and maybe SRE calling a p/invoke).

We also started a PR to explore reverting the ilgen componentization (dotnet/runtime#74675).

[dalexsoto]

As noted, the plan is to keep going on this PR and if dotnet/runtime#74675 makes the RC1 cut we will need to revert the ilgen component changes in both macios and android (/cc @jonathanpeppers ) once the RC1 runtime build flows to us.

[vs-mobiletools-engineering-service2]

🔥 Failed to compare API and create generator diff 🔥

Failed to update apidiff references

Pipeline on Agent
Hash: f67e77e54a1fd0be31654e28778d5774931dee01 [PR build]

[vs-mobiletools-engineering-service2]

💻 [PR Build] Tests on macOS Mac Catalina (10.15) passed 💻

✅ All tests on macOS Mac Catalina (10.15) passed.

Pipeline on Agent
Hash: f67e77e54a1fd0be31654e28778d5774931dee01 [PR build]

[vs-mobiletools-engineering-service2]

📚 [PR Build] Artifacts 📚

Packages generated

View packages

• Microsoft.iOS.Bundle.15.4.1019-ci.pr.gh15788.pkg
• Microsoft.iOS.Ref.15.4.1019-ci.pr.gh15788.nupkg
• Microsoft.iOS.Runtime.ios-arm.15.4.1019-ci.pr.gh15788.nupkg
• Microsoft.iOS.Runtime.ios-arm64.15.4.1019-ci.pr.gh15788.nupkg
• Microsoft.iOS.Runtime.iossimulator-arm64.15.4.1019-ci.pr.gh15788.nupkg
• Microsoft.iOS.Runtime.iossimulator-x64.15.4.1019-ci.pr.gh15788.nupkg
• Microsoft.iOS.Runtime.iossimulator-x86.15.4.1019-ci.pr.gh15788.nupkg
• Microsoft.iOS.Sdk.15.4.1019-ci.pr.gh15788.nupkg
• Microsoft.iOS.Templates.15.4.1019-ci.pr.gh15788.nupkg
• Microsoft.iOS.Windows.Sdk.15.4.1019-ci.pr.gh15788.nupkg
• Microsoft.MacCatalyst.Bundle.15.4.1019-ci.pr.gh15788.pkg
• Microsoft.MacCatalyst.Ref.15.4.1019-ci.pr.gh15788.nupkg
• Microsoft.MacCatalyst.Runtime.maccatalyst-arm64.15.4.1019-ci.pr.gh15788.nupkg
• Microsoft.MacCatalyst.Runtime.maccatalyst-x64.15.4.1019-ci.pr.gh15788.nupkg
• Microsoft.MacCatalyst.Sdk.15.4.1019-ci.pr.gh15788.nupkg
• Microsoft.MacCatalyst.Templates.15.4.1019-ci.pr.gh15788.nupkg
• Microsoft.macOS.Bundle.12.3.1019-ci.pr.gh15788.pkg
• Microsoft.macOS.Ref.12.3.1019-ci.pr.gh15788.nupkg
• Microsoft.macOS.Runtime.osx-arm64.12.3.1019-ci.pr.gh15788.nupkg
• Microsoft.macOS.Runtime.osx-x64.12.3.1019-ci.pr.gh15788.nupkg
• Microsoft.macOS.Sdk.12.3.1019-ci.pr.gh15788.nupkg
• Microsoft.macOS.Templates.12.3.1019-ci.pr.gh15788.nupkg
• Microsoft.NET.Sdk.iOS.Manifest-7.0.100-rc.1.15.4.1019-ci.pr.gh15788.nupkg
• Microsoft.NET.Sdk.MacCatalyst.Manifest-7.0.100-rc.1.15.4.1019-ci.pr.gh15788.nupkg
• Microsoft.NET.Sdk.macOS.Manifest-7.0.100-rc.1.12.3.1019-ci.pr.gh15788.nupkg
• Microsoft.NET.Sdk.tvOS.Manifest-7.0.100-rc.1.15.4.1019-ci.pr.gh15788.nupkg
• Microsoft.NET.Workload.iOS.15.4.1019-ci.pr.gh15788.msi
• Microsoft.tvOS.Bundle.15.4.1019-ci.pr.gh15788.pkg
• Microsoft.tvOS.Ref.15.4.1019-ci.pr.gh15788.nupkg
• Microsoft.tvOS.Runtime.tvos-arm64.15.4.1019-ci.pr.gh15788.nupkg
• Microsoft.tvOS.Runtime.tvossimulator-arm64.15.4.1019-ci.pr.gh15788.nupkg
• Microsoft.tvOS.Runtime.tvossimulator-x64.15.4.1019-ci.pr.gh15788.nupkg
• Microsoft.tvOS.Sdk.15.4.1019-ci.pr.gh15788.nupkg
• Microsoft.tvOS.Templates.15.4.1019-ci.pr.gh15788.nupkg
• xamarin.ios-15.13.0.215.pkg
• xamarin.mac-8.13.0.215.pkg

Pipeline on Agent XAMBOT-1100.Monterey'
Hash: f67e77e54a1fd0be31654e28778d5774931dee01 [PR build]

[vs-mobiletools-engineering-service2]

📚 [PR Build] Artifacts 📚

Packages generated

View packages

• Microsoft.iOS.Bundle.15.4.1019-ci.pr.gh15788.pkg
• Microsoft.iOS.Ref.15.4.1019-ci.pr.gh15788.nupkg
• Microsoft.iOS.Runtime.ios-arm.15.4.1019-ci.pr.gh15788.nupkg
• Microsoft.iOS.Runtime.ios-arm64.15.4.1019-ci.pr.gh15788.nupkg
• Microsoft.iOS.Runtime.iossimulator-arm64.15.4.1019-ci.pr.gh15788.nupkg
• Microsoft.iOS.Runtime.iossimulator-x64.15.4.1019-ci.pr.gh15788.nupkg
• Microsoft.iOS.Runtime.iossimulator-x86.15.4.1019-ci.pr.gh15788.nupkg
• Microsoft.iOS.Sdk.15.4.1019-ci.pr.gh15788.nupkg
• Microsoft.iOS.Templates.15.4.1019-ci.pr.gh15788.nupkg
• Microsoft.iOS.Windows.Sdk.15.4.1019-ci.pr.gh15788.nupkg
• Microsoft.MacCatalyst.Bundle.15.4.1019-ci.pr.gh15788.pkg
• Microsoft.MacCatalyst.Ref.15.4.1019-ci.pr.gh15788.nupkg
• Microsoft.MacCatalyst.Runtime.maccatalyst-arm64.15.4.1019-ci.pr.gh15788.nupkg
• Microsoft.MacCatalyst.Runtime.maccatalyst-x64.15.4.1019-ci.pr.gh15788.nupkg
• Microsoft.MacCatalyst.Sdk.15.4.1019-ci.pr.gh15788.nupkg
• Microsoft.MacCatalyst.Templates.15.4.1019-ci.pr.gh15788.nupkg
• Microsoft.macOS.Bundle.12.3.1019-ci.pr.gh15788.pkg
• Microsoft.macOS.Ref.12.3.1019-ci.pr.gh15788.nupkg
• Microsoft.macOS.Runtime.osx-arm64.12.3.1019-ci.pr.gh15788.nupkg
• Microsoft.macOS.Runtime.osx-x64.12.3.1019-ci.pr.gh15788.nupkg
• Microsoft.macOS.Sdk.12.3.1019-ci.pr.gh15788.nupkg
• Microsoft.macOS.Templates.12.3.1019-ci.pr.gh15788.nupkg
• Microsoft.NET.Sdk.iOS.Manifest-7.0.100-rc.1.15.4.1019-ci.pr.gh15788.nupkg
• Microsoft.NET.Sdk.MacCatalyst.Manifest-7.0.100-rc.1.15.4.1019-ci.pr.gh15788.nupkg
• Microsoft.NET.Sdk.macOS.Manifest-7.0.100-rc.1.12.3.1019-ci.pr.gh15788.nupkg
• Microsoft.NET.Sdk.tvOS.Manifest-7.0.100-rc.1.15.4.1019-ci.pr.gh15788.nupkg
• Microsoft.NET.Workload.iOS.15.4.1019-ci.pr.gh15788.msi
• Microsoft.tvOS.Bundle.15.4.1019-ci.pr.gh15788.pkg
• Microsoft.tvOS.Ref.15.4.1019-ci.pr.gh15788.nupkg
• Microsoft.tvOS.Runtime.tvos-arm64.15.4.1019-ci.pr.gh15788.nupkg
• Microsoft.tvOS.Runtime.tvossimulator-arm64.15.4.1019-ci.pr.gh15788.nupkg
• Microsoft.tvOS.Runtime.tvossimulator-x64.15.4.1019-ci.pr.gh15788.nupkg
• Microsoft.tvOS.Sdk.15.4.1019-ci.pr.gh15788.nupkg
• Microsoft.tvOS.Templates.15.4.1019-ci.pr.gh15788.nupkg
• xamarin.ios-15.13.0.215.pkg
• xamarin.mac-8.13.0.215.pkg

Pipeline on Agent XAMBOT-1109.Monterey
Hash: f67e77e54a1fd0be31654e28778d5774931dee01 [PR build]

[vs-mobiletools-engineering-service2]

💻 [PR Build] Tests on macOS Mac Catalina (10.15) passed 💻

✅ All tests on macOS Mac Catalina (10.15) passed.

Pipeline on Agent
Hash: f67e77e54a1fd0be31654e28778d5774931dee01 [PR build]

[vs-mobiletools-engineering-service2]

🔥 Failed to compare API and create generator diff 🔥

Failed to update apidiff references

Pipeline on Agent
Hash: f67e77e54a1fd0be31654e28778d5774931dee01 [PR build]

[vs-mobiletools-engineering-service2]

❌ [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) failed ❌

Failed tests are:

• introspection
• xammac_tests
• monotouch-test

Pipeline on Agent
Hash: f67e77e54a1fd0be31654e28778d5774931dee01 [PR build]

[vs-mobiletools-engineering-service2]

❌ [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) failed ❌

Failed tests are:

• introspection
• xammac_tests
• monotouch-test

Pipeline on Agent
Hash: f67e77e54a1fd0be31654e28778d5774931dee01 [PR build]

[vs-mobiletools-engineering-service2]

🔥 [CI Build] Test results 🔥

Test results

❌ Tests failed on VSTS: simulator tests

0 tests crashed, 1 tests failed, 222 tests passed.

Failures

❌ monotouch tests

1 tests failed, 22 tests passed.

• monotouch-test/watchOS 32-bits - simulator/Release (all optimizations): TimedOut

Html Report (VSDrops) Download

Successes

✅ bcl: All 69 tests passed. Html Report (VSDrops) Download
✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests: All 1 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ framework: All 8 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 7 tests passed. Html Report (VSDrops) Download
✅ install_source: All 1 tests passed. Html Report (VSDrops) Download
✅ introspection: All 8 tests passed. Html Report (VSDrops) Download
✅ linker: All 65 tests passed. Html Report (VSDrops) Download
✅ mac_binding_project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download
✅ mononative: All 12 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: [PR build]

[vs-mobiletools-engineering-service2]

🔥 [CI Build] Test results 🔥

Test results

❌ Tests failed on VSTS: simulator tests

0 tests crashed, 1 tests failed, 222 tests passed.

Failures

❌ mmp tests

1 tests failed, 1 tests passed.

• mmptest/macOS/Debug: Failed (Execution failed with exit code 2)

Html Report (VSDrops) Download

Successes

✅ bcl: All 69 tests passed. Html Report (VSDrops) Download
✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests: All 1 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ framework: All 8 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 7 tests passed. Html Report (VSDrops) Download
✅ install_source: All 1 tests passed. Html Report (VSDrops) Download
✅ introspection: All 8 tests passed. Html Report (VSDrops) Download
✅ linker: All 65 tests passed. Html Report (VSDrops) Download
✅ mac_binding_project: All 1 tests passed. Html Report (VSDrops) Download
✅ mononative: All 12 tests passed. Html Report (VSDrops) Download
✅ monotouch: All 23 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: [PR build]

[rolfbjarne]

Test failure are unrelated (https://github.com/xamarin/maccore/issues/2612).

[rolfbjarne]

Merging this while waiting for the revert of the ilgen componentization (dotnet/runtime#74675) to flow to us.