[dotnet] Make relase builds for desktop universal by default. Fixes #15620. #15769
Conversation
…amarin#15620. ARM64-based macOS machines are becoming more and more common, and as such it makes sense to include ARM64 builds in the app bundle when building for release. Universal builds are much slower than single-architecture builds, which is why we don't make debug builds universal. Fixes xamarin#15620.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
…Inference.targets anymore. .NET changed their logic so that Microsoft.NET.RuntimeIdentifierInference.targets is now included after our default RuntimeIdentifier computation logic. However, we need to still set SelfContained=true for app extensions, but limit it to when there's a RuntimeIdentifier (i.e. not a universal app). For Universal apps it will still be set for the build for each RuntimeIdentifier.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
We have a test that expects 'link all' to be single-arch:
NoFatCorlib: /Users/builder/azdo/_work/2/s/xamarin-macios/tests/xharness/tmp-test-dir/link all93/bin/Release/net7.0-macos/link all.app/Contents/MonoBundle/.xamarin/osx-x64/System.Private.CoreLib.dll
Expected: String ending with "link all.app/Contents/MonoBundle/System.Private.CoreLib.dll"
But was: "/Users/builder/azdo/_work/2/s/xamarin-macios/tests/xharness/tmp-test-dir/link all93/bin/Release/net7.0-macos/link all.app/Contents/MonoBundle/.xamarin/osx-x64/System.Private.CoreLib.dll"
🔥 [PR Build] Build failed 🔥Build failed for the job 'Detect API changes' Pipeline on Agent |
|
🔥 Unable to find the contents for the comment: D:\a\1\s\change-detection\results\gh-comment.md does not exist :fire Pipeline on Agent |
💻 [PR Build] Tests on macOS Mac Catalina (10.15) passed 💻✅ All tests on macOS Mac Catalina (10.15) passed. Pipeline on Agent |
❌ [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) failed ❌Failed tests are:
Pipeline on Agent |
🚀 [CI Build] Test results 🚀Test results✅ All tests passed on VSTS: simulator tests. 🎉 All 223 tests passed 🎉 Tests counts✅ bcl: All 69 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
ARM64-based macOS machines are becoming more and more common, and as such it
makes sense to include ARM64 builds in the app bundle when building for
release.
Universal builds are much slower than single-architecture builds, which is why
we don't make debug builds universal.
Fixes #15620.