Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AppKit] Fix wrong binding for NSToolbarItem.Image in Mac Catalyst. Fixes #15068. #15075

Merged
merged 1 commit into from
May 23, 2022

Conversation

rolfbjarne
Copy link
Member

Fixes #15068.

@rolfbjarne rolfbjarne added the bug If an issue is a bug or a pull request a bug fix label May 20, 2022
@vs-mobiletools-engineering-service2
Copy link
Collaborator

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent XAMBOT-1109.Monterey
Hash: e37ae308a5f63728519a21acf592b0a27a841fef

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [PR Build] Tests on macOS Mac Catalina (10.15) passed 💻

All tests on macOS Mac Catalina (10.15) passed.

Pipeline on Agent
Hash: e37ae308a5f63728519a21acf592b0a27a841fef

@vs-mobiletools-engineering-service2
Copy link
Collaborator

📋 [PR Build] API Diff 📋

API diff (for current PR)

ℹ️ API Diff (from PR only) (please review changes)

API diff: vsdrops gist

Xamarin
.NET
Xamarin vs .NET
iOS vs Mac Catalyst (.NET)

API diff (vs stable)

✅ API Diff from stable

API diff: vsdrops gist

Xamarin
.NET
Xamarin vs .NET
iOS vs Mac Catalyst (.NET)

Generator diff

ℹ️ Generator Diff (please review changes)

Pipeline on Agent XAMBOT-1044.Monterey'
Hash: e37ae308a5f63728519a21acf592b0a27a841fef

@vs-mobiletools-engineering-service2
Copy link
Collaborator

❌ [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) failed ❌

Failed tests are:

  • introspection
  • xammac_tests
  • monotouch-test

Pipeline on Agent
Hash: e37ae308a5f63728519a21acf592b0a27a841fef

Copy link
Contributor

@chamons chamons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First usage of XAMCORE_6_0!

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [CI Build] Tests passed on VSTS: simulator tests iOS. ✅

Tests passed on VSTS: simulator tests iOS.

🎉 All 60 tests passed 🎉

Pipeline on Agent XAMBOT-1109.Monterey'
Merge e37ae30 into 1477c9b

@rolfbjarne rolfbjarne merged commit 0590cf9 into xamarin:main May 23, 2022
@rolfbjarne rolfbjarne deleted the issue-15068 branch May 23, 2022 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug If an issue is a bug or a pull request a bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AppKit.NSToolbarItem.Image bound incorrectly on MacCatalyst
5 participants