[PassKit] Update bindings for Xcode 13.0 beta 1, 2 #12299

rachelkang · 2021-07-29T20:01:23Z

No beta 3, 4 updates

mandel-macaque · 2021-07-29T20:05:30Z

src/PassKit/PKEnums.cs

-	[Mac (11,0)]
-	[Watch (3,0)]
-	[iOS (9,0)]
-	[Native]
-	public enum PKPaymentSummaryItemType : ulong
-	{
-		Final,
-		Pending


Did we add these in this cycle?

sorry, confusing diffs threw me off-course here! fixing

mandel-macaque · 2021-07-29T20:06:31Z

src/passkit.cs

+		[Async (ResultTypeName = "PKServiceProviderDataCompletionResult")]
+		[Watch (8,0), iOS (15,0), Mac (12,0), MacCatalyst (15,0)]
+		[Export ("serviceProviderDataForSecureElementPass:completion:")]
+		void ServiceProviderData (PKSecureElementPass secureElementPass, Action<NSData, NSError> completion);


Missing a verb, right? CreateServiceProviderData maybe?

mandel-macaque · 2021-07-29T20:07:11Z

src/passkit.cs

+		[NoWatch, Mac (12,0), iOS (15,0), MacCatalyst (15,0)]
+		[Static]
+		[Export ("paymentCouponCodeInvalidErrorWithLocalizedDescription:")]
+		NSError CouponCodeInvalidError ([NullAllowed] string localizedDescription);


Same, Is this starting with a verb?

mandel-macaque · 2021-07-29T20:07:17Z

src/passkit.cs

+		[NoWatch, Mac (12,0), iOS (15,0), MacCatalyst (15,0)]
+		[Static]
+		[Export ("paymentCouponCodeExpiredErrorWithLocalizedDescription:")]
+		NSError CouponCodeExpiredError ([NullAllowed] string localizedDescription);


mandel-macaque · 2021-07-29T20:07:30Z

src/passkit.cs

-
+		[Deprecated (PlatformName.iOS, 15, 0)]
+		[Deprecated (PlatformName.WatchOS, 8, 0)]
+		[Deprecated (PlatformName.MacOSX, 12, 0)]


MacCatalyst?

mandel-macaque · 2021-07-29T20:07:40Z

src/passkit.cs

 		[Export ("transitBalance", ArgumentSemantic.Copy)]
 		NSDecimalNumber TransitBalance { get; }

+		[Deprecated (PlatformName.iOS, 15, 0)]
+		[Deprecated (PlatformName.WatchOS, 8, 0)]
+		[Deprecated (PlatformName.MacOSX, 12, 0)]


Same, MacCatalyst?

mandel-macaque · 2021-07-29T20:07:54Z

src/passkit.cs

-		[Deprecated (PlatformName.iOS, 14,5, message: "Use 'Blocked' instead.")] // exists in base class
-		[Deprecated (PlatformName.WatchOS, 7,4, message: "Use 'Blocked' instead.")]
+		[Deprecated (PlatformName.iOS, 15, 0, message: "Use 'Blocked' instead.")] // exists in base class
+		[Deprecated (PlatformName.WatchOS, 8, 0, message: "Use 'Blocked' instead.")]


Same, MacCatalyst?

spouliot · 2021-07-29T20:03:24Z

src/PassKit/PKEnums.cs

-	[Watch (3,0)]
-	[iOS (9,0)]
-	[Native]
-	public enum PKPaymentSummaryItemType : ulong


that's a breaking change to remove this enum type

ahh oops! thanks for catching that - diffs removed and added back and I totally missed it

spouliot · 2021-07-29T20:06:43Z

src/passkit.cs

+		[Async (ResultTypeName = "PKServiceProviderDataCompletionResult")]
+		[Watch (8,0), iOS (15,0), Mac (12,0), MacCatalyst (15,0)]
+		[Export ("serviceProviderDataForSecureElementPass:completion:")]
+		void ServiceProviderData (PKSecureElementPass secureElementPass, Action<NSData, NSError> completion);


Method needs a verb/action, prefix with Get

Calls a completion handler that returns the custom data for a Secure Element pass
https://developer.apple.com/documentation/passkit/pkpasslibrary/3747078-serviceproviderdataforsecureelem

spouliot · 2021-07-29T20:08:56Z

src/passkit.cs

+		[NoWatch, Mac (12,0), iOS (15,0), MacCatalyst (15,0)]
+		[Static]
+		[Export ("paymentCouponCodeInvalidErrorWithLocalizedDescription:")]
+		NSError CouponCodeInvalidError ([NullAllowed] string localizedDescription);


prefix with Get

spouliot · 2021-07-29T20:09:03Z

src/passkit.cs

+		[NoWatch, Mac (12,0), iOS (15,0), MacCatalyst (15,0)]
+		[Static]
+		[Export ("paymentCouponCodeExpiredErrorWithLocalizedDescription:")]
+		NSError CouponCodeExpiredError ([NullAllowed] string localizedDescription);


prefix with Get

spouliot · 2021-07-29T20:10:07Z

src/passkit.cs

@@ -1140,7 +1178,11 @@ interface PKPaymentAuthorizationControllerDelegate {
 		[MacCatalyst (14,0)]
 		[Export ("paymentAuthorizationController:didRequestMerchantSessionUpdate:")]
 		void DidRequestMerchantSessionUpdate (PKPaymentAuthorizationController controller, Action<PKPaymentRequestMerchantSessionUpdate> handler);
-
+
+		[NoWatch, Mac (12,0), iOS (15,0)]


[MacCatalyst (15,0)] ?
otherwise it's implied it existed in 13.0 (the original release)

spouliot · 2021-07-29T20:14:40Z

src/passkit.cs

+		[Export ("relyingPartyIdentifier", ArgumentSemantic.Strong)]
+		string RelyingPartyIdentifier { get; }
+
+		[iOS (15,0), Mac (12,0), MacCatalyst (15,0)]


missing [Watch]
this implies it was available in watchOS 2.0

how do I determine the availability when the docs don't indicate them and I can't find the relevant header file? (I'm assuming in this case that it's Watch (8, 0) but can never be too sure)

@rachelkang if it does, look at the diff:

+ requiresUnifiedAccessCapableDevice:(BOOL)requiresUnifiedAccessCapableDevice API_AVAILABLE(ios(15.0), watchos(8.0));

So, iOS 15 and watch 8 :) From https://github.com/xamarin/xamarin-macios/wiki/PassKit-iOS-xcode13.0-beta2

oh, I totally missed that... they are so inconsistent!!! thanks 😆

spouliot · 2021-07-29T20:46:13Z

src/passkit.cs

+	{
+		Final,
+		Pending,
+	}


^ ideally avoid moving types - it makes reviewing harder (and my earlier comment about a breaking change likely incorrect)

oops! sorry - as mentioned in the other comment, the diffs removed and re-added them later which threw me off-course here

spouliot · 2021-07-29T20:46:57Z

src/passkit.cs

+	}
+
+	[Watch (8,0), iOS (15,0), Mac (12,0), MacCatalyst (15,0)]
+	public enum PKStoredValuePassBalanceType : ulong


you can remove the : ulong since it's not [Native] anymore

spouliot · 2021-07-29T20:47:55Z

src/passkit.cs

+		NSDate ExpiryDate { get; }
+
+		[Export ("isEqualToBalance:")]
+		bool IsEqualToBalance (PKStoredValuePassBalance balance);


-> IsEqual since Balance: is the argument part of the selector

spouliot · 2021-07-29T20:48:44Z

src/passkit.cs

+		[Static]
+		[Export ("passPropertiesForPass:")]
+		[return: NullAllowed]
+		PKStoredValuePassProperties PassPropertiesForPass (PKPass pass);


-> GetPassProperties

vs-mobiletools-engineering-service2 · 2021-07-30T03:31:36Z

✅ [PR Build] Tests passed on Build. ✅

Tests passed on Build.

API diff

✅ API Diff from stable

View API diff

iOS vsdrops gist
macOS vsdrops gist
macCat vsdrops gist
macCatiOS gist
tvOS vsdrops gist
watchOS vsdrops gist

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

🎉 All 89 tests passed 🎉

Pipeline on Agent XAMBOT-1104.BigSur'
Merge 45c09b5 into 448cc6e

rolfbjarne · 2021-07-30T08:51:13Z

src/passkit.cs

+		NSDate DeferredDate { get; set; }
+	}
+
+	[Watch (8,0), Mac (12,0), iOS (15,0)]


Mac Catalyst?

vs-mobiletools-engineering-service2 · 2021-07-30T18:57:01Z

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

iOS vsdrops gist
macOS vsdrops gist
macCat vsdrops gist
macCatiOS gist
tvOS vsdrops gist
watchOS vsdrops gist

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

1 tests failed, 88 tests passed.

Failed tests

monotouch-test/Mac Catalyst/Debug [dotnet]: Failed (Tests run: 2629 Passed: 2490 Inconclusive: 35 Failed: 1 Ignored: 138)

Pipeline on Agent XAMBOT-1098.BigSur'
Merge 8ee31cc into 3766cf8

mandel-macaque · 2021-08-02T17:10:03Z

Issue is unrelated: https://github.com/xamarin/maccore/issues/2443

[PassKit] Update bindings for Xcode 13.0 beta 1, 2

7d4fd1c

rachelkang added the note-highlight Worth calling out specifically in release notes label Jul 29, 2021

rachelkang added this to the xcode13.0 milestone Jul 29, 2021

rachelkang requested review from dalexsoto and spouliot July 29, 2021 20:01

Merge branch 'main' into xcode13.0-passkit-b1-b2

e6ad561

mandel-macaque requested changes Jul 29, 2021

View reviewed changes

spouliot suggested changes Jul 29, 2021

View reviewed changes

Update based on feedback

45c09b5

rolfbjarne approved these changes Jul 30, 2021

View reviewed changes

rachelkang added 2 commits July 30, 2021 10:25

Add more missing [Catalyst]

5f8ea1f

Merge branch 'main' into xcode13.0-passkit-b1-b2

8ee31cc

mandel-macaque approved these changes Jul 30, 2021

View reviewed changes

spouliot approved these changes Aug 3, 2021

View reviewed changes

mandel-macaque merged commit 3d0ac38 into xamarin:main Aug 3, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[PassKit] Update bindings for Xcode 13.0 beta 1, 2 #12299

[PassKit] Update bindings for Xcode 13.0 beta 1, 2 #12299

rachelkang commented Jul 29, 2021

mandel-macaque Jul 29, 2021

rachelkang Jul 29, 2021

mandel-macaque Jul 29, 2021

mandel-macaque Jul 29, 2021

mandel-macaque Jul 29, 2021

mandel-macaque Jul 29, 2021

mandel-macaque Jul 29, 2021

mandel-macaque Jul 29, 2021

spouliot Jul 29, 2021

rachelkang Jul 29, 2021

spouliot Jul 29, 2021

spouliot Jul 29, 2021

spouliot Jul 29, 2021

spouliot Jul 29, 2021

spouliot Jul 29, 2021

rachelkang Jul 29, 2021

mandel-macaque Jul 29, 2021

rachelkang Jul 29, 2021

spouliot Jul 29, 2021

rachelkang Jul 29, 2021

spouliot Jul 29, 2021

spouliot Jul 29, 2021

spouliot Jul 29, 2021

vs-mobiletools-engineering-service2 commented Jul 30, 2021

rolfbjarne Jul 30, 2021

vs-mobiletools-engineering-service2 commented Jul 30, 2021

Failed tests

mandel-macaque commented Aug 2, 2021

[PassKit] Update bindings for Xcode 13.0 beta 1, 2 #12299

[PassKit] Update bindings for Xcode 13.0 beta 1, 2 #12299

Conversation

rachelkang commented Jul 29, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vs-mobiletools-engineering-service2 commented Jul 30, 2021

✅ [PR Build] Tests passed on Build. ✅

API diff

API & Generator diff

GitHub pages

🎉 All 89 tests passed 🎉

Choose a reason for hiding this comment

vs-mobiletools-engineering-service2 commented Jul 30, 2021

❌ [PR Build] Tests failed on Build ❌

API diff

API & Generator diff

GitHub pages

Test results

Failed tests

mandel-macaque commented Aug 2, 2021