[dotnet][msbuild] Do not copy .pdb files inside .app for release builds
#11153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…builds The original goal was to remove the `.dylib` from the app bundle. However some are required, even in release, so that will need to be fixed first [1] [1] xamarin#11145
|
@spouliot notes or no notes, that is the question |
dalexsoto
approved these changes
Apr 7, 2021
mandel-macaque
approved these changes
Apr 7, 2021
🔥 Tests failed catastrophically on Build (no summary found). 🔥Result file $(TEST_SUMMARY_PATH) not found. Pipeline on Agent XAMBOT-1097.Catalina |
tj-devel709
approved these changes
Apr 8, 2021
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
✅ Tests passed on Build. ✅Tests passed on Build. API diff✅ API Diff from stable View API diff🎉 All 94 tests passed 🎉Pipeline on Agent XAMBOT-1097.Catalina' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original goal was to remove the
.dylibfrom the app bundle.However some are required, even in release, so that will need to be
fixed first [1]
[1] #11145